You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "rodrigonull (via GitHub)" <gi...@apache.org> on 2024/06/17 17:04:58 UTC

[PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

rodrigonull opened a new pull request, #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433

   In this PR:
   
   - Adjust CI to be able to run the Jenkins pipelines for any branch.
   - Fix some wrong image names
   - Downgrade CI base image to Ubuntu 22.04 because Playwright does not support Ubuntu 24.04 yet. (https://github.com/microsoft/playwright/issues/30368)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433#discussion_r1644545011


##########
.ci/jenkins/Jenkinsfile.ci-main:
##########
@@ -54,8 +53,7 @@ pipeline {
                             "https://github.com/${pipelineVars.githubRepositoryOrg}/${pipelineVars.githubRepositoryName}.git",
                             "${pipelineVars.kieToolsBotGithubCredentialsId}"
                         )
-
-                        BUILD_IMAGE_REQUIRED = githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile')
+                        BUILD_IMAGE_REQUIRED = (BRANCH_NAME != 'main' || githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile'))

Review Comment:
   Right, so we need to change that... otherwise the new branches will unnecessarily build the image every time...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

Posted by "rodrigonull (via GitHub)" <gi...@apache.org>.
rodrigonull commented on code in PR #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433#discussion_r1644720574


##########
.ci/jenkins/Jenkinsfile.ci-main:
##########
@@ -54,8 +53,7 @@ pipeline {
                             "https://github.com/${pipelineVars.githubRepositoryOrg}/${pipelineVars.githubRepositoryName}.git",
                             "${pipelineVars.kieToolsBotGithubCredentialsId}"
                         )
-
-                        BUILD_IMAGE_REQUIRED = githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile')
+                        BUILD_IMAGE_REQUIRED = (BRANCH_NAME != 'main' || githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile'))

Review Comment:
   As I mentioned in my previous comment we already have the regular expression filter applied in the jobs, so they will only be triggered for the main branch and for the branches that have their names following this pattern: `0.0.x`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433#discussion_r1643553175


##########
.ci/incubator-kie-tools-ci-build.Dockerfile:
##########
@@ -1,4 +1,4 @@
-FROM cruizba/ubuntu-dind:noble-26.1.3
+FROM cruizba/ubuntu-dind:jammy-26.1.3

Review Comment:
   What's the difference between "noble" and "jammy"? :D 



##########
.ci/jenkins/Jenkinsfile.ci-main:
##########
@@ -54,8 +53,7 @@ pipeline {
                             "https://github.com/${pipelineVars.githubRepositoryOrg}/${pipelineVars.githubRepositoryName}.git",
                             "${pipelineVars.kieToolsBotGithubCredentialsId}"
                         )
-
-                        BUILD_IMAGE_REQUIRED = githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile')
+                        BUILD_IMAGE_REQUIRED = (BRANCH_NAME != 'main' || githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile'))

Review Comment:
   Is `BRANCH_NAME != 'main'` for the case of new branches? If so, maybe we could have a way to check if a tag for that stream exists or not, right? Because otherwise, all PRs for non-`main` branches will re-build the image, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

Posted by "rodrigonull (via GitHub)" <gi...@apache.org>.
rodrigonull commented on code in PR #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433#discussion_r1644269034


##########
.ci/incubator-kie-tools-ci-build.Dockerfile:
##########
@@ -1,4 +1,4 @@
-FROM cruizba/ubuntu-dind:noble-26.1.3
+FROM cruizba/ubuntu-dind:jammy-26.1.3

Review Comment:
   noble is ubuntu 24.04 and jammy is ubuntu 22.04



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Adjust CI for all branches [incubator-kie-tools]

Posted by "rodrigonull (via GitHub)" <gi...@apache.org>.
rodrigonull commented on code in PR #2433:
URL: https://github.com/apache/incubator-kie-tools/pull/2433#discussion_r1644349029


##########
.ci/jenkins/Jenkinsfile.ci-main:
##########
@@ -54,8 +53,7 @@ pipeline {
                             "https://github.com/${pipelineVars.githubRepositoryOrg}/${pipelineVars.githubRepositoryName}.git",
                             "${pipelineVars.kieToolsBotGithubCredentialsId}"
                         )
-
-                        BUILD_IMAGE_REQUIRED = githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile')
+                        BUILD_IMAGE_REQUIRED = (BRANCH_NAME != 'main' || githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile'))

Review Comment:
   Your assumption is correct. The way we filter the job run is by adding a regular expression: `(main|\d{1,2}\.\d{1,2}\.x)` in the job configuration triggers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org