You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/11/22 14:41:24 UTC

[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2019: refact: adapt apache package and dependency in all modules (Breaking Change)

javeme commented on code in PR #2019:
URL: https://github.com/apache/incubator-hugegraph/pull/2019#discussion_r1029415970


##########
pom.xml:
##########
@@ -130,16 +82,16 @@
 
     <dependencyManagement>
         <dependencies>
-            <!-- hugegraph-commons -->
+            <!-- TODO: could we merge them to hugegraph-commons only? -->

Review Comment:
   no we can't merge them, because in some scenarios it is not necessary to import both the two packages at the same time, like client or loader.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org