You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datalab.apache.org by dg...@apache.org on 2021/02/12 13:59:33 UTC

[incubator-datalab] branch DATALAB-2288 created (now 4e8c2fd)

This is an automated email from the ASF dual-hosted git repository.

dgnatyshyn pushed a change to branch DATALAB-2288
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git.


      at 4e8c2fd  Merge branch 'develop' of github.com:apache/incubator-dlab into DATALAB-2288

This branch includes the following new commits:

     new c352a1d  [DATALAB-2188]: Extended validation for library installation
     new 4e8c2fd  Merge branch 'develop' of github.com:apache/incubator-dlab into DATALAB-2288

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org


[incubator-datalab] 02/02: Merge branch 'develop' of github.com:apache/incubator-dlab into DATALAB-2288

Posted by dg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

dgnatyshyn pushed a commit to branch DATALAB-2288
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git

commit 4e8c2fd9e8c64d5c704ec11cf963aec9d59eef13
Merge: c352a1d fe5caec
Author: Dmytro_Gnatyshyn <di...@ukr.net>
AuthorDate: Fri Feb 12 15:54:10 2021 +0200

    Merge branch 'develop' of github.com:apache/incubator-dlab into DATALAB-2288

 .../src/dataengine/scripts/configure_dataengine.py          |  2 +-
 infrastructure-provisioning/src/general/conf/datalab.ini    |  2 ++
 .../src/jupyter/scripts/configure_jupyter_node.py           |  2 +-
 .../src/jupyterlab/scripts/configure_jupyterlab_node.py     |  2 +-
 .../src/rstudio/scripts/configure_rstudio_node.py           |  2 +-
 .../tensor-rstudio/scripts/configure_tensor-rstudio_node.py |  2 +-
 .../src/zeppelin/scripts/configure_zeppelin_node.py         |  2 +-
 .../src/app/administration/roles/roles.component.html       | 11 +++++------
 .../src/app/administration/roles/roles.component.scss       |  7 +------
 .../webapp/src/app/core/services/configutration.service.ts  |  2 +-
 .../app/reports/audit/audit-grid/audit-grid.component.html  |  7 ++++++-
 .../app/reports/audit/audit-grid/audit-grid.component.scss  |  4 ++--
 .../confirmation-dialog/confirmation-dialog.component.html  | 13 ++++++++++++-
 .../main/resources/webapp/src/assets/styles/_dialogs.scss   |  4 +++-
 .../self-service/src/main/resources/webapp/src/styles.scss  |  9 +++++----
 15 files changed, 43 insertions(+), 28 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org


[incubator-datalab] 01/02: [DATALAB-2188]: Extended validation for library installation

Posted by dg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

dgnatyshyn pushed a commit to branch DATALAB-2288
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git

commit c352a1d660a008b2d26848487d03cbca08c46b00
Author: Dmytro_Gnatyshyn <di...@ukr.net>
AuthorDate: Fri Feb 12 15:50:30 2021 +0200

    [DATALAB-2188]: Extended validation for library installation
---
 .../exploratory/install-libraries/install-libraries.component.ts      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
index 45bc6d5..fb6d6c4 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
@@ -219,7 +219,7 @@ export class InstallLibrariesComponent implements OnInit, OnDestroy {
           return lib.name.toLowerCase() === item.name.substring(0, item.name.lastIndexOf(':')).toLowerCase();
         });
       }
-    } else if ( this.autoComplete === 'NONE') {
+    } else if ( this.autoComplete === 'NONE' || (this.autoComplete === 'ENABLED' && !this.filteredList?.length && this.group !== 'java')) {
       this.selectedLib = {
         name: this.lib.name,
         version: this.lib.version,
@@ -232,6 +232,7 @@ export class InstallLibrariesComponent implements OnInit, OnDestroy {
 
   public addLibrary(item): void {
     if ((this.autoComplete === 'ENABLED' && !this.isLibSelected && this.filteredList?.length)
+      || this.lib.name.trim().length < 2
       || (this.selectedLib && this.selectedLib.isInSelectedList) || this.isVersionInvalid || this.autoComplete === 'UPDATING') {
       return;
     }
@@ -585,6 +586,7 @@ export class ErrorLibMessageDialogComponent {
   `
   ]
 })
+
 export class LibInfoDialogComponent {
   constructor(
     public dialogRef: MatDialogRef<ErrorLibMessageDialogComponent>,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org