You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/10/11 15:47:10 UTC
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22700
[SPARK-25712][Core][Minor] Improve usage message
## What changes were proposed in this pull request?
Currently if we run
```
./sbin/start-master.sh -h
```
We get
```
Usage: ./sbin/start-master.sh [options]
18/10/11 23:38:30 INFO Master: Started daemon with process name: 33907@C02TL2JZGTF1
18/10/11 23:38:30 INFO SignalUtils: Registered signal handler for TERM
18/10/11 23:38:30 INFO SignalUtils: Registered signal handler for HUP
18/10/11 23:38:30 INFO SignalUtils: Registered signal handler for INT
Options:
-i HOST, --ip HOST Hostname to listen on (deprecated, please use --host or -h)
-h HOST, --host HOST Hostname to listen on
-p PORT, --port PORT Port to listen on (default: 7077)
--webui-port PORT Port for web UI (default: 8080)
--properties-file FILE Path to a custom Spark properties file.
Default is conf/spark-defaults.conf.
```
We can filter out some useless output.
## How was this patch tested?
Manual test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark improveStartScript
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22700.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22700
----
commit c9a3620f1b3939fc411dc69f4b48cbe160f80808
Author: Gengliang Wang <ge...@...>
Date: 2018-10-11T15:43:24Z
improve usage message
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22700
**[Test build #97270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97270/testReport)** for PR 22700 at commit [`c9a3620`](https://github.com/apache/spark/commit/c9a3620f1b3939fc411dc69f4b48cbe160f80808).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message of star...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22700
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22700#discussion_r224533980
--- Diff: sbin/start-master.sh ---
@@ -31,7 +31,8 @@ if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
echo "Usage: ./sbin/start-master.sh [options]"
pattern="Usage:"
pattern+="\|Using Spark's default log4j profile:"
- pattern+="\|Registered signal handlers for"
+ pattern+="\|Started daemon with process name"
+ pattern+="\|Registered signal handler for"
--- End diff --
Ur, could you add this patttern to STS in this PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22700
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message ...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22700#discussion_r224537568
--- Diff: sbin/start-master.sh ---
@@ -31,7 +31,8 @@ if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
echo "Usage: ./sbin/start-master.sh [options]"
pattern="Usage:"
pattern+="\|Using Spark's default log4j profile:"
- pattern+="\|Registered signal handlers for"
+ pattern+="\|Started daemon with process name"
+ pattern+="\|Registered signal handler for"
--- End diff --
Sorry, what is STS?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message ...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22700#discussion_r224549311
--- Diff: sbin/start-master.sh ---
@@ -31,7 +31,8 @@ if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
echo "Usage: ./sbin/start-master.sh [options]"
pattern="Usage:"
pattern+="\|Using Spark's default log4j profile:"
- pattern+="\|Registered signal handlers for"
+ pattern+="\|Started daemon with process name"
+ pattern+="\|Registered signal handler for"
--- End diff --
I tried but seems that STS has bigger problem other than such output: it didn't exist after parsing option `-h`. I suggest we can do it in another JIRA/PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22700#discussion_r224539284
--- Diff: sbin/start-master.sh ---
@@ -31,7 +31,8 @@ if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
echo "Usage: ./sbin/start-master.sh [options]"
pattern="Usage:"
pattern+="\|Using Spark's default log4j profile:"
- pattern+="\|Registered signal handlers for"
+ pattern+="\|Started daemon with process name"
+ pattern+="\|Registered signal handler for"
--- End diff --
Oh, I mean `Spark Thrift Server`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message of star...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22700
**[Test build #97270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97270/testReport)** for PR 22700 at commit [`c9a3620`](https://github.com/apache/spark/commit/c9a3620f1b3939fc411dc69f4b48cbe160f80808).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22700: [SPARK-25712][Core][Minor] Improve usage message
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22700#discussion_r224502646
--- Diff: sbin/start-master.sh ---
@@ -31,7 +31,8 @@ if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
echo "Usage: ./sbin/start-master.sh [options]"
pattern="Usage:"
pattern+="\|Using Spark's default log4j profile:"
- pattern+="\|Registered signal handlers for"
+ pattern+="\|Started daemon with process name"
+ pattern+="\|Registered signal handler for"
--- End diff --
The output of `SignalUtils` is changed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message of star...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22700
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message of star...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22700
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3892/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message of star...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22700
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22700: [SPARK-25712][Core][Minor] Improve usage message of star...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22700
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97270/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org