You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "baijun44 (via GitHub)" <gi...@apache.org> on 2023/02/22 06:19:59 UTC

[GitHub] [shardingsphere] baijun44 opened a new issue, #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

baijun44 opened a new issue, #24294:
URL: https://github.com/apache/shardingsphere/issues/24294

   ## Feature Request
   ### Is your feature request related to a problem?
   yes
   ### Describe the feature you would like.
   Now I use readwriteSplitting feature and execute BatchInsert, can't get generatedKeys.
   In this situation, I use only one database (write db) ,I hope get more datasource features when sql is routed only one database.just like using druid.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1457458005

   @baijun44 Thanks for your contribution, @strongduanmu will help us review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1441589707

   Hi @baijun44 
   Would you like to submit a PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] baijun44 commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "baijun44 (via GitHub)" <gi...@apache.org>.
baijun44 commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1439737449

   > Hi @baijun44 Are you using an auto-increment primary key?
   
   yes, if I execute single insert, it works.
   I try to modify executeBatch method and cache java.sql.Statement object just like execute method does. it can run. So, I hope get official support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1439566994

   Hi @baijun44 
   Are you using an auto-increment primary key?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] baijun44 commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "baijun44 (via GitHub)" <gi...@apache.org>.
baijun44 commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1447438762

   > Hi @baijun44 Would you like to submit a PR?
   
   Yes,Let me try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] baijun44 commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "baijun44 (via GitHub)" <gi...@apache.org>.
baijun44 commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1456258685

   @RaigorJiang hello,could you help me review the code? I passed all tests on my pc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #24294:
URL: https://github.com/apache/shardingsphere/issues/24294#issuecomment-1697157607

   Fixed by #24405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu closed issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed issue #24294: return generatedKeys when use ShardingSpherePreparedStatement.executeBatch
URL: https://github.com/apache/shardingsphere/issues/24294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org