You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/02 18:45:10 UTC
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#6489: [AIRFLOW-3959] add UI filter with DAGs tags
nuclearpinguin commented on a change in pull request #6489: [AIRFLOW-3959] add UI filter with DAGs tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r341821527
##########
File path: airflow/models/dag.py
##########
@@ -1516,6 +1524,45 @@ def _test_cycle_helper(self, visit_map, task_id):
visit_map[task_id] = DagBag.CYCLE_DONE
+dagtags = Table(
+ 'dag_tag', Base.metadata,
+ Column('tag', String(100), ForeignKey('tag.name')),
+ Column('dag_id', String(100), ForeignKey('dag.dag_id')),
+)
+
+
+class Tag(Base):
+ __tablename__ = "tag"
+ name = Column(String(100), primary_key=True)
+
+ @staticmethod
+ @provide_session
+ def get_instance(name: str, session=None):
+ """
+ Selecting the tag from the DB, if doesn't exists - creates it.
Review comment:
I think the indention is unnecessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services