You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2008/10/13 20:47:07 UTC
svn commit: r704200 - in /wicket/trunk/wicket/src:
main/java/org/apache/wicket/util/resource/locator/
test/java/org/apache/wicket/markup/html/
Author: ivaynberg
Date: Mon Oct 13 11:47:07 2008
New Revision: 704200
URL: http://svn.apache.org/viewvc?rev=704200&view=rev
Log:
unroll WICKET-1868 because it broke the world
Removed:
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/packaged1_en.txt
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/packaged1_foo_bar.txt
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java?rev=704200&r1=704199&r2=704200&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java Mon Oct 13 11:47:07 2008
@@ -16,12 +16,8 @@
*/
package org.apache.wicket.util.resource.locator;
-import java.util.Arrays;
-import java.util.HashSet;
import java.util.Iterator;
import java.util.Locale;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.util.string.Strings;
@@ -54,8 +50,6 @@
*/
public class ResourceNameIterator implements Iterator<String>
{
- private static final Pattern LOCALE_PATTERN = Pattern.compile("_[a-zA-Z]{2}($|(?=_))");
-
// The locale to search for the resource file
private final Locale locale;
@@ -70,12 +64,6 @@
// The latest exact Locale used
private Locale currentLocale;
- private final HashSet<String> isoCountries = new HashSet<String>(
- Arrays.asList(Locale.getISOCountries()));
-
- private final HashSet<String> isoLanguages = new HashSet<String>(
- Arrays.asList(Locale.getISOLanguages()));
-
/**
* Construct.
*
@@ -86,13 +74,13 @@
* @param locale
* The Locale to apply
* @param extensions
- * the filname's extensions (comma separated)
+ * the filname's extensions (comma separated). Null permitted
*/
public ResourceNameIterator(String path, final String style, final Locale locale,
final String extensions)
{
this.locale = locale;
- if (extensions == null)
+ if ((extensions == null) && (path.indexOf('.') != -1))
{
this.extensions = Strings.afterLast(path, '.');
path = Strings.beforeLast(path, '.');
@@ -102,62 +90,6 @@
this.extensions = extensions;
}
- Matcher matcher = LOCALE_PATTERN.matcher(path);
- if (matcher.find())
- {
- String language = null;
- String country = null;
- String variant = null;
- int firstValidLocalePatternFragment = -1;
- do
- {
- String s = matcher.group().substring(1, 3);
- if (Character.isLowerCase(s.charAt(0)))
- {
- if (isoLanguages.contains(s))
- {
- language = s;
- firstValidLocalePatternFragment = matcher.start();
- break;
- }
- }
- }
- while (matcher.find());
-
- // did we find a language?
- if (language != null)
- {
- // check for country
- if (matcher.find())
- {
- do
- {
- String s = matcher.group().substring(1, 3);
- if (Character.isUpperCase(s.charAt(0)))
- {
- if (isoCountries.contains(s))
- {
- country = s;
- break;
- }
- }
- }
- while (matcher.find());
- }
- if (country != null)
- {
- // country found... just get the rest of the string for any variant
- if (matcher.find())
- {
- variant = path.substring(matcher.start());
- }
- }
- path = path.substring(0, firstValidLocalePatternFragment);
- localeIterator = new LocaleResourceNameIterator(path, new Locale(language,
- country != null ? country : "", variant != null ? variant : ""));
- } // else skip the whole thing... probably user specific underscores used
- }
-
styleIterator = new StyleAndVariationResourceNameIterator(path, style, null);
}
Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java?rev=704200&r1=704199&r2=704200&view=diff
==============================================================================
--- wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java (original)
+++ wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java Mon Oct 13 11:47:07 2008
@@ -65,9 +65,9 @@
final SharedResources sharedResources = Application.get().getSharedResources();
PackageResource.bind(application, PackageResourceTest.class, "packaged1.txt");
assertNotNull("resource packaged1.txt should be available as a packaged resource",
- sharedResources.get(PackageResourceTest.class, "packaged1.txt", null, null, true));
+ sharedResources.get(PackageResourceTest.class, "packaged1.txt", null, null, true));
assertNull("resource packaged2.txt should NOT be available as a packaged resource",
- sharedResources.get(PackageResourceTest.class, "packaged2.txt", null, null, true));
+ sharedResources.get(PackageResourceTest.class, "packaged2.txt", null, null, true));
}
/**
@@ -91,43 +91,14 @@
assertFalse(guard.accept(PackageResourceTest.class, "Bar.java"));
}
- /**
- * Test lenient matching
- *
- * @throws Exception
- */
- public void testLenientPackageResourceMatching() throws Exception
+ public void testInvalidPackageResource() throws Exception
{
final SharedResources sharedResources = Application.get().getSharedResources();
Resource invalidResource = new PackageResource(PackageResourceTest.class, "packaged3.txt",
- Locale.ENGLISH, null);
+ Locale.ENGLISH, null);
assertNotNull(
- "resource packaged3.txt SHOULD be available as a packaged resource even if it doesn't exist",
- invalidResource);
-
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1.txt", null, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1.txt", Locale.CHINA,
- null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1.txt", Locale.CHINA,
- "foo"));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1.txt", null, "foo"));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_en.txt", null, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_en_US.txt", null,
- null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_en_US.txt", null,
- "foo"));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_en_US.txt",
- Locale.US, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_en_US.txt",
- Locale.CANADA, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_en_US.txt",
- Locale.CHINA, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_foo_bar_en.txt",
- null, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class, "packaged1_foo_bar_en_US.txt",
- null, null));
- assertTrue(PackageResource.exists(PackageResourceTest.class,
- "packaged1_foo_bar_en_US_MAC.txt", null, null));
+ "resource packaged3.txt SHOULD be available as a packaged resource even if it doesn't exist",
+ invalidResource);
try
{
@@ -142,7 +113,6 @@
/**
* @see junit.framework.TestCase#setUp()
*/
- @Override
protected void setUp() throws Exception
{
application = new WicketTester().getApplication();