svn commit: r903485 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/ng/request/cycle/RequestCycle.java

[kn...@apache.org]

Author: knopp
Date: Tue Jan 26 23:19:54 2010
New Revision: 903485

URL: http://svn.apache.org/viewvc?rev=903485&view=rev
Log:
remove deprecation; 

Modified:
    wicket/trunk/wicket/src/main/java/org/apache/wicket/ng/request/cycle/RequestCycle.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/ng/request/cycle/RequestCycle.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/ng/request/cycle/RequestCycle.java?rev=903485&r1=903484&r2=903485&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/ng/request/cycle/RequestCycle.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/ng/request/cycle/RequestCycle.java Tue Jan 26 23:19:54 2010
@@ -291,13 +291,19 @@
 		return request;
 	}
 
-	@Deprecated
-	// TODO NG: Remove. Request should be final
-	// the only reason why the method is here is that form sets new request if the request is
-	// multipart
-	// can't this be handled by wicket filter?
+	/**
+	 * INTERNAL This method is for internal Wicket use. Do not call it yourself unless you know what
+	 * you are doing.
+	 * 
+	 * @param request
+	 */
 	public void setRequest(Request request)
 	{
+		// It would be mighty nice if request was final. However during multipart it needs to be set
+		// to
+		// MultipartServletWebRequest by Form. It can't be done before creating the request cycle
+		// (in wicket filter)
+		// because only the form knows max upload size
 		this.request = request;
 	}