You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/17 07:33:50 UTC
[GitHub] [hive] asinkovits opened a new pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
asinkovits opened a new pull request #2281:
URL: https://github.com/apache/hive/pull/2281
…anually disabled compaction
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Creates a new metric that measures the number of writes tables that has compaction turned off manually.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Subtask is part of the compaction observability initiative.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits commented on a change in pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
Posted by GitBox <gi...@apache.org>.
asinkovits commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r635842924
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
##########
@@ -687,6 +689,26 @@ static boolean equivalent(Map<String, String> lhs, Map<String, String> rhs) {
return value.isEmpty()? Collections.emptyMap() : Splitter.on(',').withKeyValueSeparator("->").split(value);
}
+ @Test
+ public void textWritesToDisabledCompactionTable() throws Exception {
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.TRANSACTIONAL_EVENT_LISTENERS, "org.apache.hadoop.hive.metastore.HMSMetricsListener");
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r636158595
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSMetricsListener.java
##########
@@ -86,4 +92,24 @@ public void onAddPartition(AddPartitionEvent partitionEvent) throws MetaExceptio
Metrics.getOrCreateGauge(MetricsConstants.TOTAL_PARTITIONS).incrementAndGet();
createdParts.inc();
}
+
+ @Override
+ public void onAllocWriteId(AllocWriteIdEvent allocWriteIdEvent, Connection dbConn, SQLGenerator sqlGenerator) throws MetaException {
+ Table table = getTable(allocWriteIdEvent);
Review comment:
Ok. Maybe add some JavaDoc about this so nobody else gets confused... but otherwise LGTM then :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits commented on a change in pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
Posted by GitBox <gi...@apache.org>.
asinkovits commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r635843838
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSMetricsListener.java
##########
@@ -86,4 +92,24 @@ public void onAddPartition(AddPartitionEvent partitionEvent) throws MetaExceptio
Metrics.getOrCreateGauge(MetricsConstants.TOTAL_PARTITIONS).incrementAndGet();
createdParts.inc();
}
+
+ @Override
+ public void onAllocWriteId(AllocWriteIdEvent allocWriteIdEvent, Connection dbConn, SQLGenerator sqlGenerator) throws MetaException {
+ Table table = getTable(allocWriteIdEvent);
Review comment:
Yeah, if i understand correctly this was already done in a tricky way.
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L482
The listener is only added if the metrics registry is initialized, which is only done when metrics are enabled.
Do you think we should explicitly add the check here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asinkovits commented on a change in pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
Posted by GitBox <gi...@apache.org>.
asinkovits commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r635842723
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
##########
@@ -687,6 +689,26 @@ static boolean equivalent(Map<String, String> lhs, Map<String, String> rhs) {
return value.isEmpty()? Collections.emptyMap() : Splitter.on(',').withKeyValueSeparator("->").split(value);
}
+ @Test
+ public void textWritesToDisabledCompactionTable() throws Exception {
Review comment:
nice :D
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp commented on a change in pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
Posted by GitBox <gi...@apache.org>.
klcopp commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r635252137
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
##########
@@ -687,6 +689,26 @@ static boolean equivalent(Map<String, String> lhs, Map<String, String> rhs) {
return value.isEmpty()? Collections.emptyMap() : Splitter.on(',').withKeyValueSeparator("->").split(value);
}
+ @Test
+ public void textWritesToDisabledCompactionTable() throws Exception {
Review comment:
nit: typo "text" -> "test"
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
##########
@@ -687,6 +689,26 @@ static boolean equivalent(Map<String, String> lhs, Map<String, String> rhs) {
return value.isEmpty()? Collections.emptyMap() : Splitter.on(',').withKeyValueSeparator("->").split(value);
}
+ @Test
+ public void textWritesToDisabledCompactionTable() throws Exception {
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.TRANSACTIONAL_EVENT_LISTENERS, "org.apache.hadoop.hive.metastore.HMSMetricsListener");
Review comment:
nit: HMSMetricsListener.class.getName() would be nicer
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSMetricsListener.java
##########
@@ -86,4 +92,24 @@ public void onAddPartition(AddPartitionEvent partitionEvent) throws MetaExceptio
Metrics.getOrCreateGauge(MetricsConstants.TOTAL_PARTITIONS).incrementAndGet();
createdParts.inc();
}
+
+ @Override
+ public void onAllocWriteId(AllocWriteIdEvent allocWriteIdEvent, Connection dbConn, SQLGenerator sqlGenerator) throws MetaException {
+ Table table = getTable(allocWriteIdEvent);
Review comment:
Before doing anything we should first check if metrics are enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] klcopp merged pull request #2281: HIVE-25079: Create new metric about number of writes to tables with m…
Posted by GitBox <gi...@apache.org>.
klcopp merged pull request #2281:
URL: https://github.com/apache/hive/pull/2281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org