You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2017/02/16 13:20:29 UTC

[GitHub] cloudstack pull request #1947: CLOUDSTACK-9789: Fix releasing secondary gues...

GitHub user ustcweizhou opened a pull request:

    https://github.com/apache/cloudstack/pull/1947

    CLOUDSTACK-9789: Fix releasing secondary guest IP fails with associated static nat which is actually not used

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ustcweizhou/cloudstack RemoveSecondaryIP

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1947.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1947
    
----
commit 0f054246b65d003ae7f024b6ef125b2ec1846879
Author: Wei Zhou <w....@tech.leaseweb.com>
Date:   2017-02-16T13:18:56Z

    CLOUDSTACK-9789: Fix releasing secondary guest IP fails with associated static nat which is actually not used

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    Packaging result: \u2716centos6 \u2714centos7 \u2714debian. JID-496


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-498


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    <b>Trillian test result (tid-842)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 33489 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1947-t842-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
    Test completed. 47 look ok, 1 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_04_rvpc_privategw_static_routes | `Failure` | 339.16 | test_privategw_acl.py
    test_01_vpc_site2site_vpn | Success | 164.89 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 66.05 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 244.85 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 285.92 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 523.25 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 504.17 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1403.08 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 557.94 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 748.66 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1296.99 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 151.32 | test_volumes.py
    test_08_resize_volume | Success | 156.01 | test_volumes.py
    test_07_resize_fail | Success | 161.01 | test_volumes.py
    test_06_download_detached_volume | Success | 155.88 | test_volumes.py
    test_05_detach_volume | Success | 150.47 | test_volumes.py
    test_04_delete_attached_volume | Success | 151.33 | test_volumes.py
    test_03_download_attached_volume | Success | 156.08 | test_volumes.py
    test_02_attach_volume | Success | 95.88 | test_volumes.py
    test_01_create_volume | Success | 710.89 | test_volumes.py
    test_deploy_vm_multiple | Success | 246.96 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.01 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.49 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.14 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 40.68 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.08 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.64 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.66 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.25 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 45.37 | test_templates.py
    test_08_list_system_templates | Success | 0.02 | test_templates.py
    test_07_list_public_templates | Success | 0.02 | test_templates.py
    test_05_template_permissions | Success | 0.03 | test_templates.py
    test_04_extract_template | Success | 5.14 | test_templates.py
    test_03_delete_template | Success | 5.08 | test_templates.py
    test_02_edit_template | Success | 90.15 | test_templates.py
    test_01_create_template | Success | 30.42 | test_templates.py
    test_10_destroy_cpvm | Success | 131.48 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.58 | test_ssvm.py
    test_08_reboot_cpvm | Success | 101.46 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.51 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.60 | test_ssvm.py
    test_05_stop_ssvm | Success | 163.53 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.24 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.07 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 10.90 | test_snapshots.py
    test_04_change_offering_small | Success | 237.32 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.02 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.14 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.08 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.11 | test_secondary_storage.py
    test_09_reboot_router | Success | 40.29 | test_routers.py
    test_08_start_router | Success | 30.32 | test_routers.py
    test_07_stop_router | Success | 10.15 | test_routers.py
    test_06_router_advanced | Success | 0.04 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.66 | test_routers.py
    test_03_restart_network_cleanup | Success | 60.39 | test_routers.py
    test_02_router_internal_adv | Success | 1.01 | test_routers.py
    test_01_router_internal_basic | Success | 0.56 | test_routers.py
    test_router_dns_guestipquery | Success | 76.70 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
    test_router_dhcphosts | Success | 276.65 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.49 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.06 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 130.69 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.02 | test_regions.py
    test_create_pvlan_network | Success | 5.13 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.28 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 502.96 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 353.38 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 86.50 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.70 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.13 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.32 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 89.81 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.45 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.25 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.16 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.22 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.29 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.23 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.22 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 92.09 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.11 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.12 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.05 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 23.27 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.21 | test_non_contigiousvlan.py
    test_01_nic | Success | 438.07 | test_nic.py
    test_releaseIP | Success | 252.01 | test_network.py
    test_reboot_router | Success | 417.62 | test_network.py
    test_public_ip_user_account | Success | 10.32 | test_network.py
    test_public_ip_admin_account | Success | 40.17 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.60 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.54 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.03 | test_network.py
    test_delete_account | Success | 337.11 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.40 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.62 | test_network.py
    test_nic_secondaryip_add_remove | Success | 206.69 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 17.71 | test_login.py
    test_assign_and_removal_lb | Success | 133.16 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 187.02 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 217.59 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.02 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.04 | test_iso.py
    test_04_extract_Iso | Success | 5.11 | test_iso.py
    test_03_delete_iso | Success | 95.09 | test_iso.py
    test_02_edit_iso | Success | 0.04 | test_iso.py
    test_01_create_iso | Success | 20.65 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 207.28 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 157.97 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 528.91 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 434.22 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.21 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.09 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 5.75 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.65 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.57 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.58 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 5.81 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.60 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.80 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.79 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 5.65 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.64 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.56 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 6.89 | test_dynamicroles.py
    test_role_account_acls | Success | 6.94 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.63 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.46 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.40 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 80.54 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 10.26 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 75.63 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 5.63 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.62 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 211.81 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 212.10 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 65.64 | test_affinity_groups.py
    test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.01 | test_staticroles.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.02 | test_primary_storage.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1947
  
    @karuturi this is ready for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---