You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/22 05:25:12 UTC

[GitHub] [commons-codec] garydgregory edited a comment on pull request #94: CODEC-303: Refactor NoOpBaseNCodec to improve test logic

garydgregory edited a comment on pull request #94:
URL: https://github.com/apache/commons-codec/pull/94#issuecomment-924597345


   While this seems like a clever use of Mockito, it hinders ease of understanding the code and maintenance IMO.
   
   Mocking is a great technique for certain use cases, this isn't one of them IMO. The current noop adapter is clear, simple, and can be stepped into while debugging if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org