You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/09/24 10:05:08 UTC
Review Request 38710: Adding "-debug" option to Falcon CLI for debug
statements to stdout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
eg. falcon entity -type feed -name in-feed.xml -submit -debug
Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
Diff: https://reviews.apache.org/r/38710/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38710: FALCON-1477: Adding "-debug" option to
Falcon CLI for debug statements to stdout.
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100951
-----------------------------------------------------------
Ship it!
Ship It!
- sandeep samudrala
On Sept. 25, 2015, 9:23 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:23 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: FALCON-1477: Adding "-debug" option to
Falcon CLI for debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/
-----------------------------------------------------------
(Updated Oct. 7, 2015, 6:17 a.m.)
Review request for Falcon.
Bugs: FALCON-1477
https://issues.apache.org/jira/browse/FALCON-1477
Repository: falcon-git
Description
-------
With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
eg. falcon entity -type feed -name in-feed.xml -submit -debug
Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconAdminCLI.java 32c0e8c
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 67420ec
client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java 98f3176
client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java 24be7f1
client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java aaf59ff
client/src/main/java/org/apache/falcon/client/FalconClient.java 20f6447
docs/src/site/twiki/FalconCLI.twiki 22003d3
Diff: https://reviews.apache.org/r/38710/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38710: FALCON-1477: Adding "-debug" option to
Falcon CLI for debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 9:23 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
eg. falcon entity -type feed -name in-feed.xml -submit -debug
Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
docs/src/site/twiki/FalconCLI.twiki 4f72bf8
Diff: https://reviews.apache.org/r/38710/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38710: FALCON-1477: Adding "-debug" option to
Falcon CLI for debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 8:31 a.m.)
Review request for Falcon.
Summary (updated)
-----------------
FALCON-1477: Adding "-debug" option to Falcon CLI for debug statements to stdout.
Repository: falcon-git
Description
-------
With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
eg. falcon entity -type feed -name in-feed.xml -submit -debug
Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
Diff: https://reviews.apache.org/r/38710/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100392
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 252)
<https://reviews.apache.org/r/38710/#comment157568>
We should rather expect a +ve value rather than any integer.
- Pallavi Rao
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100396
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
On Sept. 24, 2015, 10:29 p.m., Narayan Periwal wrote:
> > What abt FalconMetadataCLI? Don't we want to add debug option for that?
Good Suggestion. I will add debug option for FalconMetadataCLI as well.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100488
-----------------------------------------------------------
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100488
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 245)
<https://reviews.apache.org/r/38710/#comment157693>
minor nit: use StringUtils.isNotBlank?
What abt FalconMetadataCLI? Don't we want to add debug option for that?
- Sowmya Ramesh
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Sept. 24, 2015, 3:55 p.m., Balu Vellanki wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 113
> > <https://reviews.apache.org/r/38710/diff/1/?file=1083842#file1083842line113>
> >
> > It will be less confusing if we set to true/false instead of 0 and non-zero. Using int might confuse users to think 1 is info, 2 is warn etc.
Agreed. I will make it as boolean
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100423
-----------------------------------------------------------
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100423
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/client/FalconClient.java (line 113)
<https://reviews.apache.org/r/38710/#comment157619>
It will be less confusing if we set to true/false instead of 0 and non-zero. Using int might confuse users to think 1 is info, 2 is warn etc.
- Balu Vellanki
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 25, 2015, 5:43 a.m., Peeyush Bishnoi wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 253
> > <https://reviews.apache.org/r/38710/diff/1/?file=1083841#file1083841line253>
> >
> > Instead of Exception ex, can we use NumberFormatException, as parseInt throws NumberFormatException. See if it is possible.
>
> Narayan Periwal wrote:
> Making debug from String to boolean as suggested by boolean, so now we can continue with Exception ex
>
> Narayan Periwal wrote:
> Actually, now there is no need for the try-catch block
If setting debug mode to boolean , it means debug is required or not. In this scenario, upto what level of debug logs will be shown as there are multiple levels like WARN,DEBUG,ERROR,INFO etc. Can you just scope it and add documentation as well for user convenience.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100533
-----------------------------------------------------------
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Sept. 25, 2015, 5:43 a.m., Peeyush Bishnoi wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 253
> > <https://reviews.apache.org/r/38710/diff/1/?file=1083841#file1083841line253>
> >
> > Instead of Exception ex, can we use NumberFormatException, as parseInt throws NumberFormatException. See if it is possible.
>
> Narayan Periwal wrote:
> Making debug from String to boolean as suggested by boolean, so now we can continue with Exception ex
Actually, now there is no need for the try-catch block
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100533
-----------------------------------------------------------
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Sept. 25, 2015, 5:43 a.m., Peeyush Bishnoi wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 253
> > <https://reviews.apache.org/r/38710/diff/1/?file=1083841#file1083841line253>
> >
> > Instead of Exception ex, can we use NumberFormatException, as parseInt throws NumberFormatException. See if it is possible.
Making debug from String to boolean as suggested by boolean, so now we can continue with Exception ex
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100533
-----------------------------------------------------------
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: FALCON-1477: Adding "-debug" option to
Falcon CLI for debug statements to stdout.
Posted by Narayan Periwal <na...@inmobi.com>.
> On Sept. 25, 2015, 5:43 a.m., Peeyush Bishnoi wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 253
> > <https://reviews.apache.org/r/38710/diff/1/?file=1083841#file1083841line253>
> >
> > Instead of Exception ex, can we use NumberFormatException, as parseInt throws NumberFormatException. See if it is possible.
>
> Narayan Periwal wrote:
> Making debug from String to boolean as suggested by boolean, so now we can continue with Exception ex
>
> Narayan Periwal wrote:
> Actually, now there is no need for the try-catch block
>
> Peeyush Bishnoi wrote:
> If setting debug mode to boolean , it means debug is required or not. In this scenario, upto what level of debug logs will be shown as there are multiple levels like WARN,DEBUG,ERROR,INFO etc. Can you just scope it and add documentation as well for user convenience.
As of now, we just show the Web Services API details used by any commands. We are not showing the server side logs.
- Narayan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100533
-----------------------------------------------------------
On Sept. 25, 2015, 9:23 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 9:23 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38710: Adding "-debug" option to Falcon CLI for
debug statements to stdout.
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100533
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 253)
<https://reviews.apache.org/r/38710/#comment157754>
Instead of Exception ex, can we use NumberFormatException, as parseInt throws NumberFormatException. See if it is possible.
- Peeyush Bishnoi
On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 8:05 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements in Stdout.
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to the server, this can be later extended for printing more debug statements at various stages.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
>
> Diff: https://reviews.apache.org/r/38710/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>