You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/12/01 14:59:45 UTC

[GitHub] [ozone] symious opened a new pull request, #4026: HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI

symious opened a new pull request, #4026:
URL: https://github.com/apache/ozone/pull/4026

   ## What changes were proposed in this pull request?
   
   This bug in introduced in [HDDS-6308](https://issues.apache.org/jira/browse/HDDS-6308), which updates the type of "replicationFactor" from "number" to "string".
   
   This ticket is to fix this issue.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7575
   
   ## How was this patch tested?
   
   <img width="739" alt="image" src="https://user-images.githubusercontent.com/14933944/205085892-8c266a52-03ec-4068-a16e-17f70d6e33de.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] symious commented on pull request #4026: HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI

Posted by GitBox <gi...@apache.org>.
symious commented on PR #4026:
URL: https://github.com/apache/ozone/pull/4026#issuecomment-1334691517

   @kaijchen Thanks for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kaijchen merged pull request #4026: HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI

Posted by GitBox <gi...@apache.org>.
kaijchen merged PR #4026:
URL: https://github.com/apache/ozone/pull/4026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kaijchen commented on pull request #4026: HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI

Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #4026:
URL: https://github.com/apache/ozone/pull/4026#issuecomment-1334691038

   Thanks @symious for the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kaijchen commented on a diff in pull request #4026: HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI

Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #4026:
URL: https://github.com/apache/ozone/pull/4026#discussion_r1037420095


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/themeIcons.tsx:
##########
@@ -49,7 +49,7 @@ export class RatisIcon extends React.PureComponent<IRatisIconProps> {
   render() {
     const {replicationFactor, isLeader} = this.props;
     const threeFactorClass = isLeader ? 'icon-text-three-dots-leader' : 'icon-text-three-dots';
-    const textClass = replicationFactor >= 3 ? threeFactorClass : 'icon-text-one-dot';
+    const textClass = replicationFactor == "THREE" ? threeFactorClass : 'icon-text-one-dot';

Review Comment:
   ```suggestion
       const textClass = replicationFactor === "THREE" ? threeFactorClass : 'icon-text-one-dot';
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org