You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "chl-wxp (via GitHub)" <gi...@apache.org> on 2026/07/02 07:36:46 UTC

[PR] [Fix][Connector-V2] Remove incorrect HTTP entity content encoding [seatunnel]

chl-wxp opened a new pull request, #11281:
URL: https://github.com/apache/seatunnel/pull/11281

   ### Purpose
   
     Remove an incorrect `StringEntity#setContentEncoding` call in `HttpClientProvider`.
   
     The request body is already created with `ContentType.APPLICATION_JSON`, so the entity content type is set correctly. Setting content encoding with a `Content-Type: application/json` header is semantically wrong because content
     encoding should describe encodings such as gzip or deflate.
   
     ### Changes
   
     - Removed the incorrect entity content encoding assignment for JSON string request bodies.
     - Let `StringEntity(body, ContentType.APPLICATION_JSON)` handle the JSON content type.
   
     ### Impact
   
     This avoids sending misleading entity encoding metadata while preserving the existing JSON request body behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Remove incorrect HTTP entity content encoding [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11281:
URL: https://github.com/apache/seatunnel/pull/11281#issuecomment-5149758901

   Thanks for your contribution for Apache SeaTunnel. 
   
   To facilitate focused communication among contributors, we’ve created a brand-new dedicated #contributors channel in official Slack workspace.
   Slack workspace link: https://s.apache.org/seatunnel-slack
   
   This channel is designed for technical discussions, feature design brainstorming, roadmap sync and direct communication with project core Contributors. Everyone who contributes code, docs, test cases or community ideas is warmly invited to join, share thoughts and collaborate together under The Apache Way. Welcome to join us😄
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Remove incorrect HTTP entity content encoding [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11281:
URL: https://github.com/apache/seatunnel/pull/11281#issuecomment-6393812430

   Resolved the conflicts with current `dev` in `1f9edeb952ff` while retaining its newer HTTP request handling and tests.
   
   The target branch already contains the production Content-Encoding fix, so the resulting PR now adds regression coverage only. The original map-body checks remain, and the string-body path is verified through public `execute()` against the actual received JSON body, query, Content-Type and absence of Content-Encoding, replacing the reflection-only test. No production behavior or existing assertion was weakened.
   
   Affected-module Spotless passed. Fresh GitHub CI is queued on this commit; the historical Windows failure log has expired (HTTP 410), so I have not attributed or retried that old failure without evidence.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Remove incorrect HTTP entity content encoding [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11281:
URL: https://github.com/apache/seatunnel/pull/11281#issuecomment-5082478374

   I picked this up and added the missing regression coverage on the PR branch.
   
   What changed:
   - Added a JSON map-body assertion to keep the existing request header/entity contract explicit.
   - Added a focused regression test for the real string-body path changed by this PR. The test invokes the private `addBody(HttpEntityEnclosingRequestBase, String)` path and verifies:
     - `Content-Type` stays `application/json`
     - no request `Content-Encoding` header is emitted
     - the entity content encoding remains unset
     - the entity content type remains JSON
   
   This should cover the previous review blocker without changing production visibility or behavior. The latest head is `c6cda3a02269252d5d3edb8a9f325c42bba6a4a7`; GitHub CI has been retriggered and is still pending/in progress right now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2] Remove incorrect HTTP entity content encoding [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11281:
URL: https://github.com/apache/seatunnel/pull/11281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org