[jira] [Assigned] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

["Jess Balint (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jess Balint reassigned CALCITE-1792:
------------------------------------

    Assignee: Jess Balint  (was: Julian Hyde)

> RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)
> -------------------------------------------------------------------
>
>                 Key: CALCITE-1792
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1792
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Sergiy Simonov
>            Assignee: Jess Balint
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> this test fails (added in {{RelToSqlConverterTest}}):
> {code}
>     @Test public void testCartesianProductWithFullJoinSyntax() {
>     String query = "select * from \"department\"\n"
>             + "FULL JOIN \"employee\" ON TRUE";
>     String expected = "SELECT *\nFROM \"foodmart\".\"department\"\n"
>             + "FULL JOIN \"foodmart\".\"employee\" ON TRUE";
>     sql(query).ok(expected);
>   }
> {code}
> {{RelToSqlConverter}} is checking that the join condition is a {{RexCall}}. In this case (and {{RelBuilder.join()}} with no join cond), the join cond is a {{RexLiteral}} with a value of {{true}}.
> Suggested fix is to handle the case with this specific join condition before {{convertConditionToSqlNode()}}:



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)