You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by sebastiencaille <gi...@git.apache.org> on 2016/07/10 13:41:04 UTC
[GitHub] httpclient pull request #55: HTTPCLIENT-1748: fix for trunk
GitHub user sebastiencaille opened a pull request:
https://github.com/apache/httpclient/pull/55
HTTPCLIENT-1748: fix for trunk
Hello,
as discussed before, here is a patch proposal for the trunk.
(I added a basic test case)
Cheers
S�bastien
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sebastiencaille/httpclient trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 88ea39b476faf777fa2c01e4cb198a67927542e1
Author: Sebastien Caille <se...@gmail.com>
Date: 2016-06-24T15:11:34Z
HTTPCLIENT-1748: fixed proxy hostname so authentication works with java
applets (started from firefox)
commit 7a87b59e9c20f443e3123425567153204e831453
Author: Sebastien Caille <se...@gmail.com>
Date: 2016-06-24T15:19:36Z
HTTPCLIENT-1748: improved creation of proxy's HttpHost
commit f01cfa4bc82a0b73a723ed5d8fb3b0c5a05f071e
Author: Sebastien Caille <se...@gmail.com>
Date: 2016-07-03T12:50:29Z
HTTPCLIENT-1748: fix for proxy authentication issue / trunk
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request #55: HTTPCLIENT-1748: fix for trunk
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpclient/pull/55#discussion_r71292523
--- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/SystemDefaultCredentialsProvider.java ---
@@ -88,35 +93,51 @@ public void setCredentials(final AuthScope authscope, final Credentials credenti
private static PasswordAuthentication getSystemCreds(
final AuthScope authscope,
- final Authenticator.RequestorType requestorType) {
+ final Authenticator.RequestorType requestorType,
+ final HttpContext context) {
final String hostname = authscope.getHost();
final int port = authscope.getPort();
final HttpHost origin = authscope.getOrigin();
final String protocol = origin != null ? origin.getSchemeName() :
(port == 443 ? "https" : "http");
+
+ final URL targetHostURL;
+ if (context != null) {
+ final HttpUriRequest httpUriRequest = (HttpUriRequest) context.getAttribute(HttpCoreContext.HTTP_REQUEST);
--- End diff --
One cannot assume the request object in the context to be always of type of HttpUriRequest. It would be safer to use the generic HttpRequest type here.
Otherwise everything looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #55: HTTPCLIENT-1748: fix for trunk
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpclient/pull/55
Committed to SVN trunk. Please review and close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient issue #55: HTTPCLIENT-1748: fix for trunk
Posted by sebastiencaille <gi...@git.apache.org>.
Github user sebastiencaille commented on the issue:
https://github.com/apache/httpclient/pull/55
is it ok to use httpRequest.getRequestLine().getUri() instead ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org