You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2013/08/14 02:32:10 UTC
Review Request 13547: Extend listCapabilities API support to verify KVM
snapshot enabled or not
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/
-----------------------------------------------------------
Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
Bugs: cloudstack-4308
Repository: cloudstack-git
Description
-------
For 6.3 KVM, by default, snapshot is not supported. This is managed by a global setting KVM.snapshot.enabled.
UI needs the API support for listCapabilities response, to stop user to set recurring snapshot when snapshot is not supported for KVM 6.3.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
server/src/com/cloud/server/ManagementServerImpl.java 622e167
Diff: https://reviews.apache.org/r/13547/diff/
Testing
-------
Thanks,
Fang Wang
Re: Review Request 13547: Extend listCapabilities API support to verify KVM
snapshot enabled or not
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/#review25111
-----------------------------------------------------------
Review 13547 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #125 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/125/
- Jenkins Cloudstack.org
On Aug. 14, 2013, 12:46 a.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13547/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 12:46 a.m.)
>
>
> Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: cloudstack-4308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For 6.3 KVM, by default, snapshot is not supported. This is managed by a global setting KVM.snapshot.enabled.
> UI needs the API support for listCapabilities response, to stop user to set recurring snapshot when snapshot is not supported for KVM 6.3.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
> api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
> server/src/com/cloud/server/ManagementServerImpl.java 622e167
>
> Diff: https://reviews.apache.org/r/13547/diff/
>
>
> Testing
> -------
>
> Before the fix, listCapabilities does not have the KVMSnapshotEnabled field:
> "listcapabilitiesresponse": {
> "capability": {
> "securitygroupsenabled": false,
> "cloudstackversion": "4.2.0-SNAPSHOT",
> "userpublictemplateenabled": true,
> "supportELB": "false",
> "projectinviterequired": false,
> "allowusercreateprojects": true,
> "customdiskofferingmaxsize": 1024
> }
>
> I tested now with my fix, it shows:
> "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":false} <--- default value is false;
>
> I then set the default value to TRUE on MS, and call listCapabilities command again:
> { "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":true} } <---- reflect the true value.
>
> Verified the fix through the tests.
>
>
> Thanks,
>
> Fang Wang
>
>
Re: Review Request 13547: Extend listCapabilities API support to verify KVM
snapshot enabled or not
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/#review25115
-----------------------------------------------------------
Ship it!
Ship It!
- Venkata Siva Vijayendra Bhamidipati
On Aug. 14, 2013, 12:46 a.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13547/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 12:46 a.m.)
>
>
> Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: cloudstack-4308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For 6.3 KVM, by default, snapshot is not supported. This is managed by a global setting KVM.snapshot.enabled.
> UI needs the API support for listCapabilities response, to stop user to set recurring snapshot when snapshot is not supported for KVM 6.3.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
> api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
> server/src/com/cloud/server/ManagementServerImpl.java 622e167
>
> Diff: https://reviews.apache.org/r/13547/diff/
>
>
> Testing
> -------
>
> Before the fix, listCapabilities does not have the KVMSnapshotEnabled field:
> "listcapabilitiesresponse": {
> "capability": {
> "securitygroupsenabled": false,
> "cloudstackversion": "4.2.0-SNAPSHOT",
> "userpublictemplateenabled": true,
> "supportELB": "false",
> "projectinviterequired": false,
> "allowusercreateprojects": true,
> "customdiskofferingmaxsize": 1024
> }
>
> I tested now with my fix, it shows:
> "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":false} <--- default value is false;
>
> I then set the default value to TRUE on MS, and call listCapabilities command again:
> { "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":true} } <---- reflect the true value.
>
> Verified the fix through the tests.
>
>
> Thanks,
>
> Fang Wang
>
>
Re: Review Request 13547: Extend listCapabilities API support to verify KVM
snapshot enabled or not
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/#review25114
-----------------------------------------------------------
The build failure is for master, this patch is for 4.2
- Venkata Siva Vijayendra Bhamidipati
On Aug. 14, 2013, 12:46 a.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13547/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 12:46 a.m.)
>
>
> Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: cloudstack-4308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For 6.3 KVM, by default, snapshot is not supported. This is managed by a global setting KVM.snapshot.enabled.
> UI needs the API support for listCapabilities response, to stop user to set recurring snapshot when snapshot is not supported for KVM 6.3.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
> api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
> server/src/com/cloud/server/ManagementServerImpl.java 622e167
>
> Diff: https://reviews.apache.org/r/13547/diff/
>
>
> Testing
> -------
>
> Before the fix, listCapabilities does not have the KVMSnapshotEnabled field:
> "listcapabilitiesresponse": {
> "capability": {
> "securitygroupsenabled": false,
> "cloudstackversion": "4.2.0-SNAPSHOT",
> "userpublictemplateenabled": true,
> "supportELB": "false",
> "projectinviterequired": false,
> "allowusercreateprojects": true,
> "customdiskofferingmaxsize": 1024
> }
>
> I tested now with my fix, it shows:
> "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":false} <--- default value is false;
>
> I then set the default value to TRUE on MS, and call listCapabilities command again:
> { "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":true} } <---- reflect the true value.
>
> Verified the fix through the tests.
>
>
> Thanks,
>
> Fang Wang
>
>
Re: Review Request 13547: Extend listCapabilities API support to verify KVM
snapshot enabled or not
Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 12:46 a.m.)
Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
Bugs: cloudstack-4308
Repository: cloudstack-git
Description
-------
For 6.3 KVM, by default, snapshot is not supported. This is managed by a global setting KVM.snapshot.enabled.
UI needs the API support for listCapabilities response, to stop user to set recurring snapshot when snapshot is not supported for KVM 6.3.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java a30e26c
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java c2996f0
server/src/com/cloud/server/ManagementServerImpl.java 622e167
Diff: https://reviews.apache.org/r/13547/diff/
Testing (updated)
-------
Before the fix, listCapabilities does not have the KVMSnapshotEnabled field:
"listcapabilitiesresponse": {
"capability": {
"securitygroupsenabled": false,
"cloudstackversion": "4.2.0-SNAPSHOT",
"userpublictemplateenabled": true,
"supportELB": "false",
"projectinviterequired": false,
"allowusercreateprojects": true,
"customdiskofferingmaxsize": 1024
}
I tested now with my fix, it shows:
"listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":false} <--- default value is false;
I then set the default value to TRUE on MS, and call listCapabilities command again:
{ "listcapabilitiesresponse" : { "capability" : {"securitygroupsenabled":true,"cloudstackversion":"4.2.0-SNAPSHOT","userpublictemplateenabled":true,"supportELB":"false","projectinviterequired":false,"allowusercreateprojects":true,"customdiskofferingmaxsize":1024,"KVMsnapshotenabled":true} } <---- reflect the true value.
Verified the fix through the tests.
Thanks,
Fang Wang