You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/16 11:04:15 UTC

[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #3996: Fix route inclusion / exclusion filtering

aldettinger commented on code in PR #3996:
URL: https://github.com/apache/camel-quarkus/pull/3996#discussion_r946632850


##########
extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/RegistryRoutesLoaders.java:
##########
@@ -88,6 +88,15 @@ public void configure() throws Exception {
                 boolean abs = Modifier.isAbstract(routesBuilder.getClass().getModifiers());
                 if (!abs) {
                     String name = routesBuilder.getClass().getName();
+

Review Comment:
   On the top of my head, the naming pattern will no vary a lot. Plus, we would catch any breaking change via tests. So, it should be ok if I get it  well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org