[jira] [Commented] (FELIX-5499) Remove usage of json.org from dependency manager

["Pierre De Rop (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854177#comment-15854177 ] 

Pierre De Rop commented on FELIX-5499:
--------------------------------------

Carsten,

I fixed the issue in revision 1651957.

Actually, what i did is the following: since I know that David had a tiny json parser in the Converter project, I took at look at it , and I found it so simple that I ... stole it :-)
it is exactly the kind of json tool I was looking for: something little and effective. I just slightly modified it in order to make it totally standalone (no dependencies on anything).

see the json reader from [1] (it is based on the original Converter project (org.apache.felix.serializer.impl.json.JsonSerializingImpl.java)
and the json writer from [2] (it is based on original Converter project (org.apache.felix.serializer.impl.json.JsonParser.java)

now, when you will put a common json tool (reader and writer json tool) in the "common" module, I will then rework my code in order to use it.
(I hope it will be the one from the Converter module :-))

[1] http://svn.apache.org/viewvc/felix/trunk/dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/JsonWriter.java
[2] http://svn.apache.org/viewvc/felix/trunk/dependencymanager/org.apache.felix.dependencymanager.runtime/src/org/apache/felix/dm/runtime/JsonReader.java



> Remove usage of json.org from dependency manager
> ------------------------------------------------
>
>                 Key: FELIX-5499
>                 URL: https://issues.apache.org/jira/browse/FELIX-5499
>             Project: Felix
>          Issue Type: Improvement
>          Components: Dependency Manager Annotations, Dependency Manager Runtime
>    Affects Versions: org.apache.felix.dependencymanager-r1
>            Reporter: Carsten Ziegeler
>            Assignee: Pierre De Rop
>            Priority: Blocker
>             Fix For: org.apache.felix.dependencymanager-r9
>
>
> As explained in [1] we have to remove the usage of the json.org
> library from our code base as the licence is not in the excepted
> category anymore. This does not affect released code.
> [1]
> https://mail-archives.apache.org/mod_mbox/www-legal-discuss/201611.mbox/%3C0CE2E8C9-D9B7-404D-93EF-A1F8B07189BF@apache.org%3E
> This is the list of files using json.org:
> ./dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/AnnotationCollector.java:import org.json.JSONArray;
> ./dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/AnnotationCollector.java:import org.json.JSONException;
> ./dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/AnnotationCollector.java:import org.json.JSONObject;
> ./dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/EntryWriter.java:import org.json.JSONArray;
> ./dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/EntryWriter.java:import org.json.JSONException;
> ./dependencymanager/org.apache.felix.dependencymanager.annotation/src/org/apache/felix/dm/annotation/plugin/bnd/EntryWriter.java:import org.json.JSONObject;
> ./dependencymanager/org.apache.felix.dependencymanager.runtime/src/org/apache/felix/dm/runtime/DescriptorParser.java:import org.json.JSONObject;
> ./dependencymanager/org.apache.felix.dependencymanager.runtime/src/org/apache/felix/dm/runtime/JSONMetaData.java:import org.json.JSONArray;
> ./dependencymanager/org.apache.felix.dependencymanager.runtime/src/org/apache/felix/dm/runtime/JSONMetaData.java:import org.json.JSONException;
> ./dependencymanager/org.apache.felix.dependencymanager.runtime/src/org/apache/felix/dm/runtime/JSONMetaData.java:import org.json.JSONObject;



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)