[GitHub] [activemq] gemmellr commented on a change in pull request #766: [AMQ-8472] Fix reload4j scope in activemq-partition module

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #766:
URL: https://github.com/apache/activemq/pull/766#discussion_r804678655



##########
File path: activemq-partition/pom.xml
##########
@@ -92,6 +84,16 @@
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>ch.qos.reload4j</groupId>
+      <artifactId>reload4j</artifactId>
+      <scope>test</scope>

Review comment:
       Personally I would be fine with test scope if this still works when used (by dependants, not within the build tests), but just to note: this is effectively different than what it did in 5.16.3 before (and different than you said you were going to do on the JIRA) since the module wont pass on reload4j like this anymore, wheras log4j was being passed on before due to the zookeeper related bits that brought it in before (but are now excluded via dependencyManagement).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org