[GitHub] [spark] beliefer commented on a diff in pull request #40277: [SPARK-42555][CONNECT][FOLLOWUP] Add the new proto msg to support the remaining jdbc API

["beliefer (via GitHub)" <gi...@apache.org>]

beliefer commented on code in PR #40277:
URL: https://github.com/apache/spark/pull/40277#discussion_r1125854126


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -140,6 +141,21 @@ message Read {
     // (Optional) A list of path for file-system backed data sources.
     repeated string paths = 4;
   }
+
+  message PartitionedJDBC {
+    // (Required) JDBC URL.
+    string url = 1;
+
+    // (Required) Name of the table in the external database.
+    string table = 2;
+
+    // (Optional) Condition in the where clause for each partition.
+    repeated string predicates = 3;

Review Comment:
   But the transform path is very different from DataSource.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org