[GitHub] eiri opened a new pull request #767: Fix leaking chttpd's security tests config

[gi...@git.apache.org]

eiri opened a new pull request #767: Fix leaking chttpd's security tests config
URL: https://github.com/apache/couchdb/pull/767
 
 
   ## Overview
   
   We are setting custom "authentication_db" in `chttpd_security_tests`, but making this change persistent in `eunit.ini` config. As a result the rest of the tests expecting this temporary database to be a proper authentication database and getting background `chttpd_auth_cache` crashes with `database_does_not_exist` exception on attempt to pull `_design/_auth` .
   
   ## Testing recommendations
   
   Before:
   ```bash
   $ make clean
   
   $ grep authentication_db tmp/etc/*
   grep: tmp/etc/*: No such file or directory
   
   $ make eunit apps=chttpd suites=chttpd_security_tests skip_deps=couch_epi
    ...
      [done in 8.694 s]
   =======================================================
     All 8 tests passed.
   
   $ grep authentication_db tmp/etc/*
   tmp/etc/default_eunit.ini:; authentication_db = _users
   tmp/etc/default_eunit.ini:authentication_db = _users
   tmp/etc/eunit.ini:authentication_db = eunit-test-db-1503408726307396
   ```
   
   After:
   ```bash
   ...
   $ grep authentication_db tmp/etc/*
   tmp/etc/default_eunit.ini:; authentication_db = _users
   tmp/etc/default_eunit.ini:authentication_db = _users
   ```
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services