You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/05/23 14:55:19 UTC

[GitHub] [drill] cgivre commented on a diff in pull request #2558: DRILL-8232: Add support for user credentials to VaultCredentialsProvider

cgivre commented on code in PR #2558:
URL: https://github.com/apache/drill/pull/2558#discussion_r879554968


##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/security/vault/VaultCredentialsProvider.java:
##########
@@ -37,9 +40,11 @@
  */
 public class VaultCredentialsProvider implements CredentialsProvider {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(VaultCredentialsProvider.class);

Review Comment:
   Nit:  There seems to be a Drill convention to call the logger `logger` in all lower case. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org