You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/11/22 21:14:05 UTC
[GitHub] [accumulo] trietopsoft opened a new pull request #2367: Add support for LZ4 and BZip2 Codecs
trietopsoft opened a new pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367
Hadoop compression support for 'lz4' and 'bzip2' codecs. Updates javadoc and normalizes comments for lz4, bzip2, and zstd.
Implements #2366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2367: Add support for LZ4 and BZip2 Codecs
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367#issuecomment-978100847
I had to drop recent commits that are currently causing compactions to fail (see https://github.com/apache/accumulo/issues/2362) but I was able to test these changes in Uno. I was able to use the 2 new compression types with Hadoop 3.3.0 and inspected files using `accumulo rfile-info`. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2367: Add support for LZ4 and BZip2 Codecs
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367#issuecomment-978101871
Thanks for the contribution @trietopsoft and welcome to the Apache Accumulo community. If you would like to be listed as a contributor on Accumulo's people page please make a website PR for people.md. https://github.com/apache/accumulo-website/edit/main/pages/people.md
If you intend to make more contributions, please consider subscribing to the dev list and introducing yourself. Also, you can use the dev list or slack to reach out if you have questions about anything. https://accumulo.apache.org/contact-us/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] trietopsoft commented on pull request #2367: Add support for LZ4 and BZip2 Codecs
Posted by GitBox <gi...@apache.org>.
trietopsoft commented on pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367#issuecomment-976644220
@milleruntime thank you for reviewing. The deprecated classes were updated to maintain parity with the codecs available in the system. We understand these classes will no longer be supported but would like equivalent functionality during the transition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman edited a comment on pull request #2367: Add support for LZ4 and BZip2 Codecs
Posted by GitBox <gi...@apache.org>.
EdColeman edited a comment on pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367#issuecomment-975945255
The git workflow build is failing because of file formatting issues. You can run the maven build locally and it will run the formatter (as well as other checks) To run the
same command as the workflow fast build you can run:
```
mvn clean verify package javadoc:jar -Psec-bugs -DskipITs=true -DskipTests=true
```
If you get that to pass, you may want to run the unit tests at least once, commit the formatting changes and then push a new commit once the build is passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2367: Add support for LZ4 and BZip2 Codecs
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2367: Add support for LZ4 and BZip2 Codecs
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2367:
URL: https://github.com/apache/accumulo/pull/2367#issuecomment-975945255
The git workflow build is failing because of file formatting issues. You can run the maven build locally and it will run the formatter (as well as other checks) To run the
same command as the workflow fast build you can run:
```
mvn clean verify package javadoc:jar -Psec-bugs -DskipITs=true -DskipTests=true```
If you get that to pass, you may want to run the unit tests at least once, commit the formatting changes and then push a new commit once the build is passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org