You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Aleksandar Pejakovic <a....@levi9.com> on 2016/01/04 13:59:32 UTC
Review Request 41884: SAMZA-802: KafkaSystemAdmin needs to handle
empty topic offsets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41884/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
Quick fix to prevent NullPointerException.
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a
Diff: https://reviews.apache.org/r/41884/diff/
Testing
-------
Thanks,
Aleksandar Pejakovic
Re: Review Request 41884: SAMZA-802: KafkaSystemAdmin needs to handle
empty topic offsets
Posted by Bruno De Bus <br...@virdata.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41884/#review113037
-----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala (line 55)
<https://reviews.apache.org/r/41884/#comment173532>
I do not see how oldestOffsets could ever be null here: it is either an immutable.Map created on line 183 or set to the sum/union of two immutable.Maps on 193. They can never be null.
By the way:
- The modification on line 210 has no effect (as it is not reassigned to the oldestOffsets variable)
- line 212 only compiles because of the import of JavaConversions on line 33. Here the immutable oldestOffset Map gets converted to a java.util.Map (because the immutable Map does not have the put method) but if that code actually got executed it would throw an UnsupportedOperationException....
- Bruno De Bus
On Jan. 4, 2016, 12:59 p.m., Aleksandar Pejakovic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41884/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 12:59 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Quick fix to prevent NullPointerException.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a
>
> Diff: https://reviews.apache.org/r/41884/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleksandar Pejakovic
>
>
Re: Review Request 41884: SAMZA-802: KafkaSystemAdmin needs to handle
empty topic offsets
Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41884/#review112954
-----------------------------------------------------------
Ship it!
Logic seems correct.
- Boris Shkolnik
On Jan. 4, 2016, 12:59 p.m., Aleksandar Pejakovic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41884/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 12:59 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Quick fix to prevent NullPointerException.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala 9dc436a
>
> Diff: https://reviews.apache.org/r/41884/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleksandar Pejakovic
>
>