You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yjshen <gi...@git.apache.org> on 2015/09/14 11:11:48 UTC

[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

GitHub user yjshen opened a pull request:

    https://github.com/apache/spark/pull/8742

    [SPARK-10539][SQL]Fix set optimization by eliminate empty project list push down

    Push down empty project list through `Intersect` or `Except` would make all the rows in both child to empty row, which makes set operation `intersect` or `except` meaningless.
    
    JIRA: https://issues.apache.org/jira/browse/SPARK-10539

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yjshen/spark fix_set_optimization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8742
    
----
commit 040b60a980627f5d5c6cb21a61ba0758dea8cf29
Author: Yijie Shen <he...@gmail.com>
Date:   2015-09-14T09:05:38Z

    fix set optimization by eliminate empty project push down

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-141297061
  
    @yjshen The fix is good. Can you address comments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8742#discussion_r39815622
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -136,26 +136,12 @@ object SetOperationPushDown extends Rule[LogicalPlan] {
             Filter(condition, left),
             Filter(pushToRight(condition, rewrites), right))
     
    -    // Push down projection into intersect
    -    case Project(projectList, i @ Intersect(left, right)) =>
    -      val rewrites = buildRewrites(i)
    -      Intersect(
    -        Project(projectList, left),
    -        Project(projectList.map(pushToRight(_, rewrites)), right))
    -
         // Push down filter into except
         case Filter(condition, e @ Except(left, right)) =>
           val rewrites = buildRewrites(e)
           Except(
             Filter(condition, left),
             Filter(pushToRight(condition, rewrites), right))
    -
    -    // Push down projection into except
    -    case Project(projectList, e @ Except(left, right)) =>
    -      val rewrites = buildRewrites(e)
    -      Except(
    -        Project(projectList, left),
    -        Project(projectList.map(pushToRight(_, rewrites)), right))
    --- End diff --
    
    Can you add comments at here the reason that we cannot pushdown projections and why we can pushdown filters?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by yjshen <gi...@git.apache.org>.
Github user yjshen commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140075395
  
    I need to investigate more about set operator to make sure I'm doing the right thing. Close it for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140043217
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42419/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140165825
  
      [Test build #42432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42432/console) for   PR 8742 at commit [`ce6ed80`](https://github.com/apache/spark/commit/ce6ed80f1d3b7138664010a415a8501ea68dcd28).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yjshen <gi...@git.apache.org>.
Github user yjshen closed the pull request at:

    https://github.com/apache/spark/pull/8742


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140165971
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140009422
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140043089
  
      [Test build #42419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42419/console) for   PR 8742 at commit [`040b60a`](https://github.com/apache/spark/commit/040b60a980627f5d5c6cb21a61ba0758dea8cf29).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8742#discussion_r39702841
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ---
    @@ -907,4 +907,13 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
           assert(row.getDouble(1) - row.getDouble(3) === 0.0 +- 0.001)
         }
       }
    +
    +  test("SPARK-10539: Project should not be pushed down through Intersect or Except") {
    +    val df1 = (1 to 100).map(Tuple1.apply).toDF("i")
    --- End diff --
    
    nit: `sqlContext.range(100)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by yjshen <gi...@git.apache.org>.
GitHub user yjshen reopened a pull request:

    https://github.com/apache/spark/pull/8742

    [SPARK-10539][SQL]Fix set optimization by eliminate empty project list push down

    Push down empty project list through `Intersect` or `Except` would make all the rows in both child to empty row, which makes set operation `intersect` or `except` meaningless.
    
    JIRA: https://issues.apache.org/jira/browse/SPARK-10539

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yjshen/spark fix_set_optimization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8742
    
----
commit 040b60a980627f5d5c6cb21a61ba0758dea8cf29
Author: Yijie Shen <he...@gmail.com>
Date:   2015-09-14T09:05:38Z

    fix set optimization by eliminate empty project push down

commit ce6ed80f1d3b7138664010a415a8501ea68dcd28
Author: Yijie Shen <he...@gmail.com>
Date:   2015-09-14T16:30:38Z

    Project should not be pushed down through Intersect or Except

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140135561
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yjshen <gi...@git.apache.org>.
Github user yjshen commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-141873047
  
    Thanks @yhuai, I'll close this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8742#discussion_r39474132
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -136,26 +136,12 @@ object SetOperationPushDown extends Rule[LogicalPlan] {
             Filter(condition, left),
             Filter(pushToRight(condition, rewrites), right))
     
    -    // Push down projection into intersect
    -    case Project(projectList, i @ Intersect(left, right)) =>
    -      val rewrites = buildRewrites(i)
    -      Intersect(
    -        Project(projectList, left),
    -        Project(projectList.map(pushToRight(_, rewrites)), right))
    -
         // Push down filter into except
         case Filter(condition, e @ Except(left, right)) =>
           val rewrites = buildRewrites(e)
           Except(
             Filter(condition, left),
             Filter(pushToRight(condition, rewrites), right))
    -
    -    // Push down projection into except
    -    case Project(projectList, e @ Except(left, right)) =>
    -      val rewrites = buildRewrites(e)
    -      Except(
    -        Project(projectList, left),
    -        Project(projectList.map(pushToRight(_, rewrites)), right))
    --- End diff --
    
    Can we add comments in this class to explain why we cannot pushdown projections? For filter pushdown, if the condition has non-deterministic expressions, it is not safe to pushdown filters for some cases. But, it will not be the case because of https://github.com/apache/spark/pull/7446. But, it is still good to think about if there is any case that filter pushdown is not safe. If we determine it is safe to do filter pushdown, let's add comments to explain the reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140009449
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yjshen <gi...@git.apache.org>.
Github user yjshen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8742#discussion_r39478700
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -136,26 +136,12 @@ object SetOperationPushDown extends Rule[LogicalPlan] {
             Filter(condition, left),
             Filter(pushToRight(condition, rewrites), right))
     
    -    // Push down projection into intersect
    -    case Project(projectList, i @ Intersect(left, right)) =>
    -      val rewrites = buildRewrites(i)
    -      Intersect(
    -        Project(projectList, left),
    -        Project(projectList.map(pushToRight(_, rewrites)), right))
    -
         // Push down filter into except
         case Filter(condition, e @ Except(left, right)) =>
           val rewrites = buildRewrites(e)
           Except(
             Filter(condition, left),
             Filter(pushToRight(condition, rewrites), right))
    -
    -    // Push down projection into except
    -    case Project(projectList, e @ Except(left, right)) =>
    -      val rewrites = buildRewrites(e)
    -      Except(
    -        Project(projectList, left),
    -        Project(projectList.map(pushToRight(_, rewrites)), right))
    --- End diff --
    
    @yhuai, thanks for your comment. I didn't consider non-deterministic filters' effect on push down when I was doing this, I will think about it and make comments soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140184801
  
    cc @yhuai for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140165974
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42432/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140135612
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140935988
  
    ping :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140012512
  
      [Test build #42419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42419/consoleFull) for   PR 8742 at commit [`040b60a`](https://github.com/apache/spark/commit/040b60a980627f5d5c6cb21a61ba0758dea8cf29).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-141523674
  
    @yjshen I added the comments and create a new PR (https://github.com/apache/spark/pull/8823). Can you close this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by yjshen <gi...@git.apache.org>.
Github user yjshen closed the pull request at:

    https://github.com/apache/spark/pull/8742


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Fix set optimization by elim...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140043216
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10539][SQL]Project should not be pushed...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8742#issuecomment-140136499
  
      [Test build #42432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42432/consoleFull) for   PR 8742 at commit [`ce6ed80`](https://github.com/apache/spark/commit/ce6ed80f1d3b7138664010a415a8501ea68dcd28).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org