[GitHub] [doris] cambyzju commented on a diff in pull request #10749: [feature-wip] (array-type) function concat_ws support array

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #10749:
URL: https://github.com/apache/doris/pull/10749#discussion_r917512744


##########
be/src/vec/functions/function_string.h:
##########
@@ -540,6 +542,11 @@ class FunctionStringConcatWs : public IFunction {
             } else {
                 null_list[i] = &const_null_map->get_data();
             }
+
+            if (is_array(remove_nullable(block.get_by_position(arguments[i]).type))) {

Review Comment:
   also can use check_column<ColumnArray>, then we do not need to consider nullable again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org