[GitHub] incubator-hawq pull request #1225: HAWQ-1446: Introduce vectorized profile f...

[denalex <gi...@git.apache.org>]

Github user denalex commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1225#discussion_r118129347
  
    --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java ---
    @@ -289,7 +289,7 @@ private void fetchMetaData(HiveTablePartition tablePartition, boolean hasComplex
             if (inputData.getProfile() != null) {
                 // evaluate optimal profile based on file format if profile was explicitly specified in url
                 // if user passed accessor+fragmenter+resolver - use them
    -            profile = ProfileFactory.get(fformat, hasComplexTypes);
    +            profile = ProfileFactory.get(fformat, hasComplexTypes, inputData.getProfile());
    --- End diff --
    
    getProfile() is called twice (in if statement and here, its better to call once and then evaluate and reuse the variable)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---