You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/10 00:04:53 UTC
Review Request: FLAGS (2): Integrated Configurator and Flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5855/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/configurator/configurator.hpp 8569645
src/configurator/configurator.cpp da07abf
src/flags/flags.hpp PRE-CREATION
src/tests/flags_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/5855/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: FLAGS (2): Integrated Configurator and Flags.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5855/#review9037
-----------------------------------------------------------
Ship it!
src/flags/flags.hpp
<https://reviews.apache.org/r/5855/#comment19197>
kill trailing ws
- John Sirois
On July 9, 2012, 10:04 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5855/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 10:04 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/configurator/configurator.hpp 8569645
> src/configurator/configurator.cpp da07abf
> src/flags/flags.hpp PRE-CREATION
> src/tests/flags_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5855/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>