[GitHub] [flink] luoyuxia commented on a diff in pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928517671


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends TableEnvironment {
      * @param operation The operation to be executed.
      * @return the content of the execution result.
      */
+    TableResultInternal executeOperation(Operation operation);

Review Comment:
   We can just  implement the delegation in `executeInternal`. The reason I add `executeOperation` is to make the whole logic clear,  like first try to use external implementation , and then `executeInternal` which is Flink's implementation.
   I'm fine to put the delegation in `executeInternal`. 
   
   The reason Why no `executeOperation(List<ModifyOperation> operations)` is I don't want to expose much to user and I think it's no nesscessary. Now, this method is mainly used by `StatementSetOperation`. And if extern dialect wants to custom the implementation for the operation containing multi-insert,  extern dialect can  return a new operation like `HiveStatementSetOperation` and then still delegate it to `executeOperation(Operation operation)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org