You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/02 15:40:40 UTC

[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #2118: [Bug] [seatunnel-connector-flink-fake] Type is not supported: BigInteger

ruanwenjun commented on code in PR #2118:
URL: https://github.com/apache/incubator-seatunnel/pull/2118#discussion_r912374515


##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-fake/src/main/java/org/apache/seatunnel/flink/fake/source/MockSchema.java:
##########
@@ -132,6 +132,7 @@ public TypeInformation<?> typeInformation() {
                 dataType = BasicTypeInfo.SHORT_TYPE_INFO;
                 break;
             case "long":
+            case "bigint":

Review Comment:
   I don't think we need to add `bigint`, since we already has `BigInteger`, and I see the [Jmock doc](https://github.com/jsonzou/jmockdata#java对象), they did support `bigint`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org