You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by si...@apache.org on 2022/01/14 04:45:52 UTC
[pinot] branch master updated: Extract common logic of generating columns parameter into a function (#7989)
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ca08968 Extract common logic of generating columns parameter into a function (#7989)
ca08968 is described below
commit ca089681483bb3066890d0ff9b4cea25428b1d12
Author: Liang Mingqiang <mi...@linkedin.com>
AuthorDate: Thu Jan 13 20:45:37 2022 -0800
Extract common logic of generating columns parameter into a function (#7989)
---
.../util/ServerSegmentMetadataReader.java | 31 +++++++++++-----------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java b/pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
index 4ee509a..7afd0a7 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java
@@ -173,14 +173,7 @@ public class ServerSegmentMetadataReader {
String endpoint) {
try {
tableNameWithType = URLEncoder.encode(tableNameWithType, StandardCharsets.UTF_8.name());
- String paramsStr = "";
- if (columns != null) {
- List<String> params = new ArrayList<>(columns.size());
- for (String column : columns) {
- params.add(String.format("columns=%s", column));
- }
- paramsStr = String.join("&", params);
- }
+ String paramsStr = generateColumnsParam(columns);
return String.format("%s/tables/%s/metadata?%s", endpoint, tableNameWithType, paramsStr);
} catch (UnsupportedEncodingException e) {
throw new RuntimeException(e.getCause());
@@ -192,17 +185,23 @@ public class ServerSegmentMetadataReader {
try {
tableNameWithType = URLEncoder.encode(tableNameWithType, StandardCharsets.UTF_8.name());
segmentName = URLEncoder.encode(segmentName, StandardCharsets.UTF_8.name());
- String paramsStr = "";
- if (columns != null) {
- List<String> params = new ArrayList<>(columns.size());
- for (String column : columns) {
- params.add(String.format("columns=%s", column));
- }
- paramsStr = String.join("&", params);
- }
+ String paramsStr = generateColumnsParam(columns);
return String.format("%s/tables/%s/segments/%s/metadata?%s", endpoint, tableNameWithType, segmentName, paramsStr);
} catch (UnsupportedEncodingException e) {
throw new RuntimeException(e.getCause());
}
}
+
+ private String generateColumnsParam(List<String> columns) {
+ String paramsStr = "";
+ if (columns == null || columns.isEmpty()) {
+ return paramsStr;
+ }
+ List<String> params = new ArrayList<>(columns.size());
+ for (String column : columns) {
+ params.add(String.format("columns=%s", column));
+ }
+ paramsStr = String.join("&", params);
+ return paramsStr;
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org