You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/03/22 20:03:35 UTC

[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs

GitHub user karensmolermiller opened a pull request:

    https://github.com/apache/geode-native/pull/69

    GEODE-2513 Unbrand C++ API docs

    Please review, paying the most attention to scoped class/function name changes.
    @davebarnes97 @joeymcallister @PivotalSarge @echobravopapa @mmartell @dgkimura @mhansonP


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karensmolermiller/geode-native feature/GEODE-2513-13

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-native/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit dfaf5db8bb919d02e435934366b6b3ed61e5ab04
Author: Karen Miller <km...@pivotal.io>
Date:   2017-03-22T19:55:27Z

    GEODE-2513 Unbrand C++ API docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs

Posted by scmbuildguy <gi...@git.apache.org>.
Github user scmbuildguy commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/69#discussion_r107524018
  
    --- Diff: docs/geode-native-docs/cpp-caching-api/accessing-entry.html.md.erb ---
    @@ -35,11 +35,11 @@ for ( int32_t i=0; i< 100; i++) {
     
     ## <a id="concept_2B85EC4AB9FA446998147A1539D818CC__section_80F9A9E8F8514A9FBA19106C2473B370" class="no-quick-link"></a>Bulk Get Operations Using getAll
     
    -You can use the `Region::getAll` API (`Region.GetAll` for .NET) to get values for an array of keys from the local cache or server. If the value for a key is not present locally, then it is requested from the server.
    +You can use the `Region::getAll` methond to get values for an array of keys from the local cache or server. If the value for a key is not present locally, then it is requested from the server.
    --- End diff --
    
    Spelling error


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs

Posted by davebarnes97 <gi...@git.apache.org>.
Github user davebarnes97 commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/69#discussion_r107524367
  
    --- Diff: docs/geode-native-docs/cpp-caching-api/accessing-entry.html.md.erb ---
    @@ -35,11 +35,11 @@ for ( int32_t i=0; i< 100; i++) {
     
     ## <a id="concept_2B85EC4AB9FA446998147A1539D818CC__section_80F9A9E8F8514A9FBA19106C2473B370" class="no-quick-link"></a>Bulk Get Operations Using getAll
     
    -You can use the `Region::getAll` API (`Region.GetAll` for .NET) to get values for an array of keys from the local cache or server. If the value for a key is not present locally, then it is requested from the server.
    +You can use the `Region::getAll` methond to get values for an array of keys from the local cache or server. If the value for a key is not present locally, then it is requested from the server.
    --- End diff --
    
    in cpp-caching-api/accessing-entry.html.md.erb, "methond" should be "method".



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode-native/pull/69


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---