You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/24 08:21:45 UTC
[GitHub] [incubator-seatunnel] zhaomin1423 opened a new pull request, #2877: Move Handover to common module
zhaomin1423 opened a new pull request, #2877:
URL: https://github.com/apache/incubator-seatunnel/pull/2877
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
There is a common class that is using in multiple module.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on pull request #2877: [Improve]Move Handover to common module
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2877:
URL: https://github.com/apache/incubator-seatunnel/pull/2877#issuecomment-1256908731
Please help me review it, there is a minor improve. @CalvinKirs @Hisoka-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on a diff in pull request #2877: [Improve]Move Handover to common module
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on code in PR #2877:
URL: https://github.com/apache/incubator-seatunnel/pull/2877#discussion_r979227774
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/Handover.java:
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.seatunnel.connectors.seatunnel.pulsar.source.reader;
+package org.apache.seatunnel.common;
Review Comment:
It is also used in seatunnel-translation-spark, it don't depend on the connector-common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2877: [Improve]Move Handover to common module
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2877:
URL: https://github.com/apache/incubator-seatunnel/pull/2877#discussion_r979220611
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/Handover.java:
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.seatunnel.connectors.seatunnel.pulsar.source.reader;
+package org.apache.seatunnel.common;
Review Comment:
Is it possible to use it in non-connector modules?
I mean it might be better to move to `connector-common` module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2877: [Improve]Move Handover to common module
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2877:
URL: https://github.com/apache/incubator-seatunnel/pull/2877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org