You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by ag...@apache.org on 2020/02/08 23:58:45 UTC

[incubator-nuttx] 01/03: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT

This is an automated email from the ASF dual-hosted git repository.

aguettouche pushed a commit to branch pr232
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 429c8b8a9e755d0bb19290cfb4419bec4c9a9bc0
Author: Gregory Nutt <gn...@nuttx.org>
AuthorDate: Sat Feb 8 12:37:30 2020 -0600

    Kconfig:  Fix unmet dependencies on ARCH_PHY_INTERRUPT
    
    Fix new warnings in the build test output.  The warnings were were of the form "... selects ARCH_PHY_INTERRUPT which has unmet dependencies (NETDEVICES && ARCH_HAVE_PHY).  This was observed on the s32k148evb:nsh configuration.
    
    I assume that this is because of the NETDEVICES dependency.  In most cases, the 'select ARCH_PHY_INTERRUPT' depended on NETDEVICES, but that was not the case for i.MX RT, S32K1xx, and Tiva.  This commit adds that dependency to the select like:
    
    	select ARCH_PHY_INTERRUPT if NETDEVICES
    
    as it is done in all other Kconfig files that select ARCH_PHY_INTERRUPT.
---
 arch/arm/src/imxrt/Kconfig   | 2 +-
 arch/arm/src/s32k1xx/Kconfig | 2 +-
 arch/arm/src/tiva/Kconfig    | 2 +-
 drivers/net/Kconfig          | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/src/imxrt/Kconfig b/arch/arm/src/imxrt/Kconfig
index 0e1518f..826bc59 100644
--- a/arch/arm/src/imxrt/Kconfig
+++ b/arch/arm/src/imxrt/Kconfig
@@ -190,7 +190,7 @@ config IMXRT_ENET
 	bool "Ethernet"
 	default n
 	select ARCH_HAVE_PHY
-	select ARCH_PHY_INTERRUPT
+	select ARCH_PHY_INTERRUPT if NETDEVICES
 	select ARCH_HAVE_NETDEV_STATISTICS
 
 config IMXRT_LCD
diff --git a/arch/arm/src/s32k1xx/Kconfig b/arch/arm/src/s32k1xx/Kconfig
index 63e0cd9..1ccb548 100644
--- a/arch/arm/src/s32k1xx/Kconfig
+++ b/arch/arm/src/s32k1xx/Kconfig
@@ -80,7 +80,7 @@ config S32K1XX_HAVE_ENET
 	bool
 	default n
 	select ARCH_HAVE_PHY
-	select ARCH_PHY_INTERRUPT
+	select ARCH_PHY_INTERRUPT if NETDEVICES
 	select ARCH_HAVE_NETDEV_STATISTICS
 
 config S32K1XX_HAVE_EWM
diff --git a/arch/arm/src/tiva/Kconfig b/arch/arm/src/tiva/Kconfig
index 861ade5..f955410 100644
--- a/arch/arm/src/tiva/Kconfig
+++ b/arch/arm/src/tiva/Kconfig
@@ -1599,7 +1599,7 @@ endif # !TIVA_PHY_INTERNAL
 
 config TIVA_PHY_INTERRUPTS
 	bool "PHY interrupt support"
-	select ARCH_PHY_INTERRUPT
+	select ARCH_PHY_INTERRUPT if NETDEVICES
 	select NETDEV_PHY_IOCTL
 	default n
 	---help---
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 176e7ac..6ddf981 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -380,7 +380,7 @@ config ETH0_PHY_DP83848C
 config ETH0_PHY_TJA1100
 	bool "NXP TJA1100 PHY"
 	select ARCH_PHY_100BASE_T1
-	
+
 config ETH0_PHY_TJA1101
 	bool "NXP TJA1101 PHY"
 	select ARCH_PHY_100BASE_T1
@@ -436,7 +436,7 @@ config ETH1_PHY_DP83848C
 config ETH1_PHY_TJA1100
 	bool "NXP TJA1100 PHY"
 	select ARCH_PHY_100BASE_T1
-	
+
 config ETH1_PHY_TJA1101
 	bool "NXP TJA1101 PHY"
 	select ARCH_PHY_100BASE_T1