You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Nandor Kollar (Code Review)" <ge...@cloudera.org> on 2026/08/03 11:21:31 UTC
[Impala-ASF-CR] IMPALA-14684: Add metrics for catalogd table invalidations
Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24166/10/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java:
http://gerrit.cloudera.org:8080/#/c/24166/10/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@372
PS10, Line 372: ttlInvalidations10Sec = countInvalidationsInWindow(ttlInvalidationBatches_,
nit: you can calculate all of these metrics in a single iteration, there's no need to iterate through the invalidation batches for each metrics. Probably doesn't worth the effort to fix it, as this it's not on the hot path.
--
To view, visit http://gerrit.cloudera.org:8080/24166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab
Gerrit-Change-Number: 24166
Gerrit-PatchSet: 10
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Aug 2026 11:21:31 +0000
Gerrit-HasComments: Yes