You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/09/26 21:49:10 UTC
[PR] Handle ENTER key correctly in trigger form and allow manual JSON [airflow]
jscheffl opened a new pull request, #42525:
URL: https://github.com/apache/airflow/pull/42525
Follow-up of #42487
related: #42157
Unfortunately a bit more JavaScript is needed but this enables:
- Handling of press of ENTER in input fields and ensure that JSON form is submitted and correct value is sent
- Handling of manual changes of JSON dict (fix before: was always over-writing JSON)
@dannyl1u - can you confirm from your side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle ENTER key correctly in trigger form and allow manual JSON [airflow]
Posted by "dannyl1u (via GitHub)" <gi...@apache.org>.
dannyl1u commented on PR #42525:
URL: https://github.com/apache/airflow/pull/42525#issuecomment-2378010297
> Follow-up of #42487
>
> related: #42157
>
> Unfortunately a bit more JavaScript is needed but this enables:
>
> * Handling of press of ENTER in input fields and ensure that JSON form is submitted and correct value is sent
> * Handling of manual changes of JSON dict (fix before: was always over-writing JSON)
>
> @dannyl1u - can you confirm from your side?
Taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle ENTER key correctly in trigger form and allow manual JSON [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #42525:
URL: https://github.com/apache/airflow/pull/42525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle ENTER key correctly in trigger form and allow manual JSON [airflow]
Posted by "dannyl1u (via GitHub)" <gi...@apache.org>.
dannyl1u commented on PR #42525:
URL: https://github.com/apache/airflow/pull/42525#issuecomment-2378023837
@jscheffl tested your branch locally, works good for me. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle ENTER key correctly in trigger form and allow manual JSON [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #42525:
URL: https://github.com/apache/airflow/pull/42525#issuecomment-2378730580
Thanks, cherrypick PR is here https://github.com/apache/airflow/pull/42535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org