[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #929: ci: should deploy code in master branch to the online demo

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r532997579



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as a version number, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       `ENABLE_PROXY` is not needed;

##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -4,6 +4,9 @@ on:
   push:
     branches:
       - master
+  pull_request:
+    branches:
+      - master

Review comment:
       emmm No

##########
File path: docs/deploy-with-docker.zh-CN.md
##########
@@ -38,6 +38,9 @@ $ docker build -t apisix-dashboard:$tag .
 
 # 对于中国大陆的用户，可启用 `ENABLE_PROXY` 参数加快模块下载速度。
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# 如果需要使用最新代码构建，可启用 `APISIX_DASHBOARD_VERSION` 参数指定为 `master` ，此参数也可以指定为其他版本号，如 `v2.0` 。

Review comment:
       ditto

##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as a version number, such as `v2.0`.

Review comment:
       xxx version string, actually the release branch's name

##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 

Review comment:
       codes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org