You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/24 03:16:01 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25443: [SPARK-28723][SQL] Upgrade to Hive 2.3.6 for HiveMetastore Client and Hadoop-3.2 profile

dongjoon-hyun commented on a change in pull request #25443: [SPARK-28723][SQL] Upgrade to Hive 2.3.6 for HiveMetastore Client and Hadoop-3.2 profile
URL: https://github.com/apache/spark/pull/25443#discussion_r317342672
 
 

 ##########
 File path: sql/hive-thriftserver/v2.3.5/src/main/scala/org/apache/spark/sql/hive/thriftserver/ThriftserverShimUtils.scala
 ##########
 @@ -17,6 +17,11 @@
 
 package org.apache.spark.sql.hive.thriftserver
 
 Review comment:
   During JDK11 testing and review, we has been skipped renaming in order to focus JDK11 related stuff by minimizing PR diff. We may need to rename this file directory `v2.3.5` to `v2.3.6` again for consistency later. If the test pass, I'd like to merge this AS-IS PR first.
   
   cc @gatorsmile , @srowen 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org