[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13301: [fix][python] schedule unexpect offline each time update from api

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #13301:
URL: https://github.com/apache/dolphinscheduler/pull/13301#discussion_r1059018830


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/SchedulerService.java:
##########
@@ -128,12 +128,11 @@ Schedule getSchedule(User loginUser,
      * @param projectCode project code
      * @param id scheduler id
      * @param scheduleStatus schedule status
-     * @return publish result code
      */
-    Map<String, Object> setScheduleState(User loginUser,
-                                         long projectCode,
-                                         Integer id,
-                                         ReleaseState scheduleStatus);
+    void setScheduleState(User loginUser,

Review Comment:
   Just curious, why to make setScheduleState no more return value? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org