You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/05 08:31:13 UTC
[GitHub] [apisix-go-plugin-runner] spacewander opened a new pull request #18: docs: pkg.go.dev will render '//' comment as part of docs
spacewander opened a new pull request #18:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #18: docs: pkg.go.dev will render '//' comment as part of docs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #18:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/18#issuecomment-873917552
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fecca24) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/746d738ebab2d474d3646fad737a51c76e2de159?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (746d738) will **decrease** coverage by `1.83%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/graphs/tree.svg?width=650&height=150&src=pr&token=BPFYE6AVQ3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 78.41% 76.57% -1.84%
==========================================
Files 9 9
Lines 491 491
==========================================
- Hits 385 376 -9
- Misses 83 92 +9
Partials 23 23
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/main.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9tYWluLmdv) | `35.38% <ø> (ø)` | |
| [cmd/go-runner/plugins/say.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL3NheS5nbw==) | `71.42% <ø> (ø)` | |
| [cmd/go-runner/version.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci92ZXJzaW9uLmdv) | `100.00% <ø> (ø)` | |
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `96.58% <ø> (ø)` | |
| [internal/http/response.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXNwb25zZS5nbw==) | `100.00% <ø> (ø)` | |
| [internal/plugin/conf.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL2NvbmYuZ28=) | `90.69% <ø> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `77.35% <ø> (ø)` | |
| [internal/server/error.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL2Vycm9yLmdv) | `100.00% <ø> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `57.39% <ø> (-7.83%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [746d738...fecca24](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #18: docs: pkg.go.dev will render '//' comment as part of docs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #18:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/18#issuecomment-873917552
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fecca24) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/746d738ebab2d474d3646fad737a51c76e2de159?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (746d738) will **decrease** coverage by `1.83%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/graphs/tree.svg?width=650&height=150&src=pr&token=BPFYE6AVQ3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
- Coverage 78.41% 76.57% -1.84%
==========================================
Files 9 9
Lines 491 491
==========================================
- Hits 385 376 -9
- Misses 83 92 +9
Partials 23 23
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/main.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9tYWluLmdv) | `35.38% <ø> (ø)` | |
| [cmd/go-runner/plugins/say.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL3NheS5nbw==) | `71.42% <ø> (ø)` | |
| [cmd/go-runner/version.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci92ZXJzaW9uLmdv) | `100.00% <ø> (ø)` | |
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `96.58% <ø> (ø)` | |
| [internal/http/response.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXNwb25zZS5nbw==) | `100.00% <ø> (ø)` | |
| [internal/plugin/conf.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL2NvbmYuZ28=) | `90.69% <ø> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `77.35% <ø> (ø)` | |
| [internal/server/error.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL2Vycm9yLmdv) | `100.00% <ø> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `57.39% <ø> (-7.83%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [746d738...fecca24](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/18?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #18: docs: pkg.go.dev will render '//' comment as part of docs
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #18:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #18: docs: pkg.go.dev will render '//' comment as part of docs
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #18:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org