You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/10/05 14:01:38 UTC
Review Request 62788: Added support/ to the list of the linted
directories.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62788/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-6390
https://issues.apache.org/jira/browse/MESOS-6390
Repository: mesos
Description
-------
By adding the support directory to 'mesos-style.py', we make sure
that all our support scripts follow the same code style that the
rest of our Python codebase uses.
We add invalid-name to 'pylint.config' as all the Python files
in support/ use dashes instead of underscores and we also add
'file-ignored' as we do not lint 'support/post-reviews.py' yet.
Diffs
-----
src/python/pylint.config 9f0361d160fa82038ccefcbc146e52f0af8f99e8
support/mesos-style.py bab7f5e0699e4f8faa0ac973551cac5773d1b1fe
support/post-reviews.py 5ecde40553c6b1ace9bfcf27a7268450b8bc2838
Diff: https://reviews.apache.org/r/62788/diff/1/
Testing
-------
Thanks,
Armand Grillet
Re: Review Request 62788: Added support/ to the list of the linted
directories.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62788/#review187182
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Oct. 5, 2017, 2:01 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62788/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2017, 2:01 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-6390
> https://issues.apache.org/jira/browse/MESOS-6390
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By adding the support directory to 'mesos-style.py', we make sure
> that all our support scripts follow the same code style that the
> rest of our Python codebase uses.
>
> We add invalid-name to 'pylint.config' as all the Python files
> in support/ use dashes instead of underscores and we also add
> 'file-ignored' as we do not lint 'support/post-reviews.py' yet.
>
>
> Diffs
> -----
>
> src/python/pylint.config 9f0361d160fa82038ccefcbc146e52f0af8f99e8
> support/mesos-style.py bab7f5e0699e4f8faa0ac973551cac5773d1b1fe
> support/post-reviews.py 5ecde40553c6b1ace9bfcf27a7268450b8bc2838
>
>
> Diff: https://reviews.apache.org/r/62788/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Armand Grillet
>
>