You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2019/07/09 14:23:27 UTC

[GitHub] [tomcat] markt-asf commented on issue #178: Bug 63556 - Mark request as forwarded in RemoteIpValve/RemoteIpFilter

markt-asf commented on issue #178: Bug 63556 - Mark request as forwarded in RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509663648
 
 
   Only a couple of minor comments.
   
   - We try and keep the changelog to a maximum width of 80 chars. We probably don't need to these days but convention for that file seems to be keep to 80 chars.
   - Why the constant in org.apache.coyote.Constants? As far as I can tell all uses of this constant are (and will be) in org.apache.catalina
   
   Otherwise, looks good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org