You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/08/10 08:21:56 UTC
[GitHub] [submarine] tangzhankun commented on pull request #372: SUBMARINE-580. Add an api for user login
tangzhankun commented on pull request #372:
URL: https://github.com/apache/submarine/pull/372#issuecomment-671224440
@Eroschang, this seems not a complete feature.
And a big problem is that checking user login on the client-side seems not secure. We should implement API in the submarine server and pass the user info to it from the client-side.
In my mind, there are three parts:
1. Some submarine server JAVA REST API:
Login/logout API
The login API should return a token so that the client can re-use it. Not pretty sure of this part.
2. submarine SDK:
generate the login/logout client Python library with the Swagger tool
3. Add login check in the experiment Python library
Add checking login logic before every experiment runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org