You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/25 10:39:46 UTC
[GitHub] [superset] codecov-io commented on pull request #12731: chore[explore]: Save date if Ok not clicked
codecov-io commented on pull request #12731:
URL: https://github.com/apache/superset/pull/12731#issuecomment-766723046
# [Codecov](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=h1) Report
> Merging [#12731](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=desc) (3e5af1b) into [master](https://codecov.io/gh/apache/superset/commit/bcbd8f93261fb599a109af011d70685fccbeb2b1?el=desc) (bcbd8f9) will **increase** coverage by `3.21%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12731 +/- ##
==========================================
+ Coverage 62.75% 65.97% +3.21%
==========================================
Files 1021 1022 +1
Lines 49960 49992 +32
Branches 4891 4892 +1
==========================================
+ Hits 31352 32980 +1628
+ Misses 18408 16881 -1527
+ Partials 200 131 -69
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `45.97% <28.57%> (?)` | |
| javascript | `60.87% <61.53%> (+<0.01%)` | :arrow_up: |
| python | `63.54% <ø> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/controls/DateFilterControl/frame/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DdXN0b21GcmFtZS50c3g=) | `14.28% <ø> (ø)` | |
| [...ls/DateFilterControl/frame/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9EYXRlRnVuY3Rpb25Ub29sdGlwLnRzeA==) | `58.33% <58.33%> (ø)` | |
| [...controls/DateFilterControl/frame/AdvancedFrame.tsx](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9BZHZhbmNlZEZyYW1lLnRzeA==) | `24.00% <100.00%> (+3.16%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [...frontend/src/components/SupersetResourceSelect.tsx](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC50c3g=) | `64.51% <0.00%> (-2.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.14% <0.00%> (-1.04%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/superset/pull/12731/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=footer). Last update [bcbd8f9...0001963](https://codecov.io/gh/apache/superset/pull/12731?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org