You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/04 18:58:36 UTC

[GitHub] [incubator-nuttx] acassis opened a new issue #2219: Recent modifications on testbuild.sh makes it difficult to know if the compilation succeed or failed

acassis opened a new issue #2219:
URL: https://github.com/apache/incubator-nuttx/issues/2219


   Previously the NuttX compilation was finished clearly:
   
   LD: nuttx
   make[1]: Leaving directory 'xxxx'
   CP: nuttx.hex
   CP: nuttx.bin
   
   Now it is completely messed:
   
   LD: nuttx
   make[1]: Leaving directory 'xxxx'
   echo nuttx > nuttx.manifest
   printf "%s\n" *.map >> nuttx.manifest
   CP: nuttx.hex
   echo nuttx.hex >> nuttx.manifest
   CP: nuttx.bin
   echo nuttx.bin >> nuttx.manifest
   
   I suggest we don't show these garbage to the users.
   
   Also should be interesting to show:
   "NuttX was compiled with Success!"
   
   This way the user will know everything worked correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton closed issue #2219: Recent modifications on testbuild.sh makes it difficult to know if the compilation succeed or failed

Posted by GitBox <gi...@apache.org>.
btashton closed issue #2219:
URL: https://github.com/apache/incubator-nuttx/issues/2219


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on issue #2219: Recent modifications on testbuild.sh makes it difficult to know if the compilation succeed or failed

Posted by GitBox <gi...@apache.org>.
acassis commented on issue #2219:
URL: https://github.com/apache/incubator-nuttx/issues/2219#issuecomment-721966570


   Hi @btashton, I agree that there are many parts that are verbose now by default. but this modification makes it hard to the end user know if everything compiled correct. My fault I just "git grep" nuttx.manifest. I will submit a patch adding $(Q) as @v01d suggested. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on issue #2219: Recent modifications on testbuild.sh makes it difficult to know if the compilation succeed or failed

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on issue #2219:
URL: https://github.com/apache/incubator-nuttx/issues/2219#issuecomment-721966570


   Hi @btashton, I agree that there are many parts that are verbose now by default, but this modification makes it hard to the end user to know whether everything compiled correct or not. Sorry, my fault, I just "git grep" nuttx.manifest. I will submit a patch adding $(Q) as @v01d suggested. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on issue #2219: Recent modifications on testbuild.sh makes it difficult to know if the compilation succeed or failed

Posted by GitBox <gi...@apache.org>.
btashton commented on issue #2219:
URL: https://github.com/apache/incubator-nuttx/issues/2219#issuecomment-721930482


   I would not call it "completely messed" it's just the output of a build. It's also not part of testbuild it is the make files generating the manifest.
   
   If you don't like the lines then just add a @ infront of them. We have lots of loud parts of the build besides this (like wget and curl which should be silent)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on issue #2219: Recent modifications on testbuild.sh makes it difficult to know if the compilation succeed or failed

Posted by GitBox <gi...@apache.org>.
v01d commented on issue #2219:
URL: https://github.com/apache/incubator-nuttx/issues/2219#issuecomment-721965495


   Better to use $(Q) so that it can appear when building with V=1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org