You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/25 21:26:12 UTC

[GitHub] [airflow] potiuk edited a comment on pull request #13308: Adds missing python-ldap dependency to LDAP extra.

potiuk edited a comment on pull request #13308:
URL: https://github.com/apache/airflow/pull/13308#issuecomment-751284240


   > I am thinking of a code similar to the following.
   > 
   > ```python
   > subprocess.run(['docker', '--rm',  $DOCKER_IMAGE, 'python', '-c', 'import ldap'])
   > ```
   
   I do not see a reason we should treat it differently. If we add it, we should add it for all packages not only for this library - we have plenty of other packages and possibly we should add them all this way. But that should be a separate change where we identify all such libraries and check if they can be imported/used? Maybe just create an issue for it with all such libraries. Maybe you can creat an issue for it ?
   
   UPDATE: I added an issue: #13315 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org