You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2026/04/05 22:57:19 UTC
(spark) branch master updated: [SPARK-55667][PYTHON][CONNECT][FOLLOW-UP] Remove arguments in check_dependencies
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 6767941022e3 [SPARK-55667][PYTHON][CONNECT][FOLLOW-UP] Remove arguments in check_dependencies
6767941022e3 is described below
commit 6767941022e36d5498cc0dd51e58536a568451dd
Author: Tian Gao <ga...@hotmail.com>
AuthorDate: Mon Apr 6 07:57:07 2026 +0900
[SPARK-55667][PYTHON][CONNECT][FOLLOW-UP] Remove arguments in check_dependencies
### What changes were proposed in this pull request?
Remove the argument for `check_dependencies` in an end to end test
### Why are the changes needed?
In https://github.com/apache/spark/pull/54463 we changed `check_dependencies` but this scala test was not modified properly. CI did not catch it because when `check_dependencies` is given the wrong number of arguments, it just raises an error - the same behavior as the dependency is not there. So the related tests believe we are missing dependencies and skip all the tests.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Locally confirmed the test runs now.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #55189 from gaogaotiantian/fix-dependency-check.
Authored-by: Tian Gao <ga...@hotmail.com>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
.../test/scala/org/apache/spark/sql/connect/PythonTestDepsChecker.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/connect/server/src/test/scala/org/apache/spark/sql/connect/PythonTestDepsChecker.scala b/sql/connect/server/src/test/scala/org/apache/spark/sql/connect/PythonTestDepsChecker.scala
index 83a9f508c53a..2f7f2fd677b5 100644
--- a/sql/connect/server/src/test/scala/org/apache/spark/sql/connect/PythonTestDepsChecker.scala
+++ b/sql/connect/server/src/test/scala/org/apache/spark/sql/connect/PythonTestDepsChecker.scala
@@ -28,7 +28,7 @@ object PythonTestDepsChecker {
pythonExec,
"-c",
"from pyspark.sql.connect.utils import check_dependencies;" +
- "check_dependencies('pyspark.sql.connect.fake_module')"),
+ "check_dependencies()"),
None,
"PYTHONPATH" -> s"$pysparkPythonPath:$pythonPath").!!
true
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org