[jira] [Closed] (FLINK-31187) Standalone HA mode does not work if dynamic properties are supplied

["Gyula Fora (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-31187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gyula Fora closed FLINK-31187.
------------------------------
    Fix Version/s: kubernetes-operator-1.5.0
       Resolution: Fixed

merged to main 2af2c99d251bb84c77200f2896260bbe72a3ee6f

> Standalone HA mode does not work if dynamic properties are supplied
> -------------------------------------------------------------------
>
>                 Key: FLINK-31187
>                 URL: https://issues.apache.org/jira/browse/FLINK-31187
>             Project: Flink
>          Issue Type: Bug
>          Components: Kubernetes Operator
>    Affects Versions: kubernetes-operator-1.4.0
>            Reporter: Mate Czagany
>            Assignee: Mate Czagany
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: kubernetes-operator-1.5.0
>
>         Attachments: standalone-ha.yaml
>
>
> With FLINK-30518 '--host $(POD_IP)' has been added to the arguments of the JMs which fixes the issue with HA on standalone mode, but it always gets appended to the end of the final JM arguments: https://github.com/usamj/flink-kubernetes-operator/blob/72ec9d384def3091ce50c2a3e2a06cded3b572e6/flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/decorators/CmdStandaloneJobManagerDecorator.java#L107
> But this will not be parsed properly in case any dynamic properties were set in the arguments, e.g.:
> {code:java}
>  Program Arguments:
>    --configDir
>    /opt/flink/conf
>    -D
>    jobmanager.memory.off-heap.size=134217728b
>    -D
>    jobmanager.memory.jvm-overhead.min=201326592b
>    -D
>    jobmanager.memory.jvm-metaspace.size=268435456b
>    -D
>    jobmanager.memory.heap.size=469762048b
>    -D
>    jobmanager.memory.jvm-overhead.max=201326592b
>    --job-classname
>    org.apache.flink.streaming.examples.statemachine.StateMachineExample
>    --test
>    test
>    --host
>    172.17.0.11{code}
> You can verify this bug by using the YAML I've attached and in the JM logs you can see this line: 
> {code:java}
> Remoting started; listening on addresses :[akka.tcp://flink@flink-example-statemachine.flink:6123]{code}
> Without any program arguments supplied this would correctly be:
> {code:java}
> Remoting started; listening on addresses :[akka.tcp://flink@172.17.0.8:6123]{code}
> I believe this could be easily fixed by appending the --host parameter before JobSpec.args and if a committer can assign this ticket to me I can create a PR for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)