You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "skrho (JIRA)" <ji...@apache.org> on 2014/09/01 12:04:20 UTC
[jira] [Updated] (HIVE-7306) Ineffective null check in
GenericUDAFAverage#GenericUDAFAverageEvaluatorDouble#getNextResult()
[ https://issues.apache.org/jira/browse/HIVE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
skrho updated HIVE-7306:
------------------------
Attachment: HIVE-7306.patch
Here is patch...
I chanaged null check logic using if/else statement
Please review my source..and give me a chance to contribute source
> Ineffective null check in GenericUDAFAverage#GenericUDAFAverageEvaluatorDouble#getNextResult()
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-7306
> URL: https://issues.apache.org/jira/browse/HIVE-7306
> Project: Hive
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HIVE-7306.patch
>
>
> {code}
> Object[] o = ss.intermediateVals.remove(0);
> Double d = o == null ? 0.0 : (Double) o[0];
> r = r == null ? null : r - d;
> cnt = cnt - ((Long) o[1]);
> {code}
> Array o is accessed without null check in the last line above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)